Skip to content

Conversation

@vbabich
Copy link
Contributor

@vbabich vbabich commented Dec 9, 2025

Use isSortable flag to determine if colBy or rowBy source is sortable.

Tested by running this query and clicking on rowBy/columnBy headers to sort -

from deephaven_enterprise.pivot.pivot_table import make_pivot
from deephaven import agg
t = db.historical_table("LearnDeephaven","StockQuotes") \
    .where("Date=`2017-08-25`")
# AskExchange and BidExchange are StringSet columns, not sortable
pivot = make_pivot(
    t,
    [agg.avg(["Bid"])],
    ["USym", "AskExchange"],
    ["Exchange", "BidExchange"],
)

Split out the hooks file into separate files, based on a review comment from another PR.

@vbabich vbabich changed the title fix: Use isSortable flag to determine if colBy or rowBy source is sortable fix: Use isSortable flag to determine if colBy and rowBy sources are sortable Dec 9, 2025
@vbabich vbabich self-assigned this Dec 9, 2025
@vbabich vbabich force-pushed the use-issortable-flag branch from 7e1fbc8 to 575cccb Compare December 10, 2025 20:46
@vbabich vbabich marked this pull request as ready for review December 10, 2025 21:41
@vbabich vbabich requested a review from mofojed December 10, 2025 21:41
@vbabich vbabich merged commit e748cd7 into deephaven:main Dec 10, 2025
18 checks passed
@vbabich vbabich deleted the use-issortable-flag branch December 10, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants