-
Notifications
You must be signed in to change notification settings - Fork 45
Support overriding API key at request-time #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9fb521e
Add context utility for request-time API keys
keyurva 89b78b9
Add tests for context API key utility
keyurva a7ff930
Use context API key in base API endpoint
keyurva 7fc300c
Support optional API keys
keyurva 7074bd8
Propagate API key context to graph worker threads
keyurva 102cc52
Fix context propagation in NodeEndpoint and add integration tests
keyurva 7697c25
Format files
keyurva 1c404fc
Address gemini comments
keyurva 72e9b0c
Address review comments
keyurva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from datacommons_client.utils.context import _API_KEY_CONTEXT_VAR | ||
| from datacommons_client.utils.context import use_api_key | ||
|
|
||
|
|
||
| def test_use_api_key_sets_var(): | ||
| """Test that use_api_key sets the context variable.""" | ||
| assert _API_KEY_CONTEXT_VAR.get() is None | ||
| with use_api_key("test-key"): | ||
| assert _API_KEY_CONTEXT_VAR.get() == "test-key" | ||
| assert _API_KEY_CONTEXT_VAR.get() is None | ||
|
|
||
|
|
||
| def test_use_api_key_nested(): | ||
| """Test nested usage of use_api_key.""" | ||
| with use_api_key("outer"): | ||
| assert _API_KEY_CONTEXT_VAR.get() == "outer" | ||
| with use_api_key("inner"): | ||
| assert _API_KEY_CONTEXT_VAR.get() == "inner" | ||
| assert _API_KEY_CONTEXT_VAR.get() == "outer" | ||
| assert _API_KEY_CONTEXT_VAR.get() is None | ||
|
|
||
|
|
||
| def test_use_api_key_none(): | ||
| """Test that use_api_key with None/empty does not set the variable.""" | ||
| assert _API_KEY_CONTEXT_VAR.get() is None | ||
| with use_api_key(None): | ||
| assert _API_KEY_CONTEXT_VAR.get() is None | ||
| with use_api_key(""): | ||
| assert _API_KEY_CONTEXT_VAR.get() is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from contextlib import contextmanager | ||
| from contextvars import ContextVar | ||
| from typing import Generator | ||
|
|
||
| _API_KEY_CONTEXT_VAR: ContextVar[str | None] = ContextVar("api_key", | ||
| default=None) | ||
|
|
||
|
|
||
| @contextmanager | ||
| def use_api_key(api_key: str | None) -> Generator[None, None, None]: | ||
| """Context manager to set the API key for the current execution context. | ||
|
|
||
| If api_key is None or empty, this context manager does nothing, allowing | ||
| the underlying client to use its default API key. | ||
|
|
||
| Args: | ||
| api_key: The API key to use. If None or empty, no change is made. | ||
|
|
||
| Example: | ||
| from datacommons_client import use_api_key | ||
| # ... | ||
| client = DataCommonsClient(api_key="default-key") | ||
keyurva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Uses "default-key" | ||
| client.observation.fetch(...) | ||
|
|
||
| with use_api_key("temp-key"): | ||
| # Uses "temp-key" | ||
| client.observation.fetch(...) | ||
|
|
||
| # Back to "default-key" | ||
| client.observation.fetch(...) | ||
| """ | ||
| if not api_key: | ||
| yield | ||
| return | ||
|
|
||
| token = _API_KEY_CONTEXT_VAR.set(api_key) | ||
| try: | ||
| yield | ||
| finally: | ||
| _API_KEY_CONTEXT_VAR.reset(token) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.