-
Notifications
You must be signed in to change notification settings - Fork 45
Support overriding API key at request-time #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @keyurva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a use_api_key context manager to allow overriding the API key for specific requests. This is a valuable feature for multi-tenant applications. The implementation correctly uses contextvars to manage the key, ensuring it's propagated to worker threads for asynchronous operations. The changes are well-tested, with new unit tests for the context manager and integration tests for both synchronous and threaded client methods.
My review includes a couple of suggestions to improve code style and consistency:
- Moving a local import to the top of the file to adhere to PEP 8.
- Aligning the testing style in a new test file with the existing
pytestconventions for better project consistency.
Overall, this is a great addition to the client library.
clincoln8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks Keyur!
Are you planning on publishing to TestPyPi first?
Will we update the python v2 docs to include info about this option?
keyurva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
Are you planning on publishing to TestPyPi first?
Yes. Will follow the release process in https://github.com/datacommonsorg/api-python/blob/master/docs/release.md which includes publishing to TestPyPi
Will we update the python v2 docs to include info about this option?
Hmm - not sure if users of the library will be using this option so not sure about updating docs either.
WDYT? Also, @kmoscoe - thoughts?
use_api_keycontext manager to override the API key for specific request scopes.node.fetch_place_ancestors).