BUG: fix the regex to parse the dtype category from the docstring#418
Merged
ev-br merged 1 commit intodata-apis:masterfrom Feb 8, 2026
Merged
BUG: fix the regex to parse the dtype category from the docstring#418ev-br merged 1 commit intodata-apis:masterfrom
ev-br merged 1 commit intodata-apis:masterfrom
Conversation
This was make a bunch of test_signature tests fail / be xfailed. The core of the change is that the regex was looking for `x1: array` while from 2024.12 the text was `x1: Union[array | int]` etc.
This was referenced Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was making a bunch of test_signature tests fail / be xfailed. The core of the change is that the regex was looking for
x1: arraywhile from 2024.12 the text wasx1: Union[array | int]etc.This was mostly harmless, modulo bitwise functions (
bitwise_left_shiftetc) which we incorrectly classed as being able to receive"numeric"inputs.The regex fix is by copilot.