Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several test_signatures.py-related expected-failure entries for bitwise functions/operators from backend-specific xfail lists, based on the upstream array-api-tests parsing fix referenced in data-apis/array-api-tests#418.
Changes:
- Removed xfails for
test_func_signature[...]for bitwise functions (bitwise_and,bitwise_or, shifts,bitwise_xor) across NumPy (latest/dev/1.26), CuPy, and PyTorch lists. - Removed PyTorch xfails for corresponding operator method signature tests (
__and__,__or__,__xor__,__lshift__,__rshift__).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| torch-xfails.txt | Drops bitwise function + operator method signature xfails under the 2024.12 section. |
| numpy-xfails.txt | Drops bitwise function signature xfails under the 2024.12 section. |
| numpy-dev-xfails.txt | Drops bitwise function signature xfails under the 2024.12 section. |
| numpy-1-26-xfails.txt | Drops bitwise function signature xfails under the 2024.12 section. |
| cupy-xfails.txt | Drops bitwise function signature xfails under the 2024.12 section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Were caused by failures in parsing, should be fixed by data-apis/array-api-tests#418