fix: scroll to correct module when navigating from Quick Access Panel#20306
Open
vtyrtov wants to merge 1 commit intodarktable-org:masterfrom
Open
fix: scroll to correct module when navigating from Quick Access Panel#20306vtyrtov wants to merge 1 commit intodarktable-org:masterfrom
vtyrtov wants to merge 1 commit intodarktable-org:masterfrom
Conversation
When clicking 'go to full version' in the Quick Access Panel, the view would sometimes scroll to a wrong module (though the correct tab was always selected). This happened because dtgtk_expander_set_expanded() was a no-op when the target module was already expanded, leaving stale _last_expanded and _start_pos values from a previous expansion. The _expander_resize callback would then either skip scrolling or scroll to the wrong widget. Add an 'else if(expanded)' branch that updates scroll tracking even when the expander state hasn't changed. Setting _start_pos.height to 0 ensures _expander_resize detects a size change and triggers scrolling. Fixes: darktable-org#19692
1 task
Member
|
Do you have a reproducer? Seems like it needs some special procedure as not reproducing in all cases. As we are at it, while testing I found another issue worth fixing at the same time.
See that it moves to tone tab but all modules (except exposure) are collapsed. Seems like this violate the preference. Can you have a look at this? TIA. |
TurboGit
added
bugfix
Contributor
Author
|
Yes, reproduces here. Will check the second issue too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking 'go to full version' in the Quick Access Panel, the view would sometimes scroll to a wrong module (though the correct tab was always selected). This happened because dtgtk_expander_set_expanded() was a no-op when the target module was already expanded, leaving stale _last_expanded and _start_pos values from a previous expansion. The _expander_resize callback would then either skip scrolling or scroll to the wrong widget.
Add an 'else if(expanded)' branch that updates scroll tracking even when the expander state hasn't changed. Setting _start_pos.height to 0 ensures _expander_resize detects a size change and triggers scrolling.
Fixes: #19692