Skip to content

fix(webapp): truncate SEO titles on tag and source pages #5683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nimrodkra merged 3 commits into from
Mar 9, 2026
+21 −8
Merged

fix(webapp): truncate SEO titles on tag and source pages #5683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b26cfa3
fix(webapp): use templated SEO titles for tag and source pages
nimrodkra Mar 9, 2026
38e6257
Merge branch 'main' into seo/pr1-title-truncation
nimrodkra Mar 9, 2026
1b22720
Merge branch 'main' into seo/pr1-title-truncation
nimrodkra Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/webapp/pages/sources/[source].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import Custom404 from '../404';
import { defaultOpenGraph, defaultSeo } from '../../next-seo';
import { mainFeedLayoutProps } from '../../components/layouts/MainFeedPage';
import { getLayout } from '../../components/layouts/FeedLayout';
import { getPageSeoTitles } from '../../components/layouts/utils';
import { SourceActions } from '../../../shared/src/components/sources/SourceActions';
import type { DynamicSeoProps } from '../../components/common';
import { getAppOrigin } from '../../lib/seo';
Expand Down Expand Up @@ -352,10 +353,14 @@ export async function getStaticProps({
}

const { source } = res;
const seoTitles = getPageSeoTitles(`${source.name} posts`);
const seo: NextSeoProps = {
title: `${source.name} posts on daily.dev`,
openGraph: { ...defaultOpenGraph },
...defaultSeo,
...seoTitles,
openGraph: {
...defaultOpenGraph,
...seoTitles.openGraph,
},
description: source?.description || defaultSeo.description,
};

Expand Down
20 changes: 14 additions & 6 deletions packages/webapp/pages/tags/[tag].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ import Link from '@dailydotdev/shared/src/components/utilities/Link';
import CustomFeedOptionsMenu from '@dailydotdev/shared/src/components/CustomFeedOptionsMenu';
import { useContentPreference } from '@dailydotdev/shared/src/hooks/contentPreference/useContentPreference';
import { ContentPreferenceType } from '@dailydotdev/shared/src/graphql/contentPreference';
import { getPageSeoTitles } from '../../components/layouts/utils';
import { getLayout } from '../../components/layouts/FeedLayout';
import { mainFeedLayoutProps } from '../../components/layouts/MainFeedPage';
import type { DynamicSeoProps } from '../../components/common';
Expand Down Expand Up @@ -554,12 +555,19 @@ interface TagPageParams extends ParsedUrlQuery {
const getSeoData = (
title: string,
description = `Find all the recent posts, videos, updates and discussions about ${title}`,
): NextSeoProps => ({
title: `${title} posts on daily.dev`,
openGraph: { ...defaultOpenGraph },
...defaultSeo,
description,
});
): NextSeoProps => {
const seoTitles = getPageSeoTitles(`${title} posts`);

return {
...defaultSeo,
...seoTitles,
openGraph: {
...defaultOpenGraph,
...seoTitles.openGraph,
},
description,
};
};

export async function getStaticProps({
params,
Expand Down