[#2845] Replace fractional mouse_scroll_steps with per-element scroll speed calculations#2846
Open
oznogon wants to merge 1 commit intodaid:masterfrom
Open
[#2845] Replace fractional mouse_scroll_steps with per-element scroll speed calculations#2846oznogon wants to merge 1 commit intodaid:masterfrom
oznogon wants to merge 1 commit intodaid:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
mouse_scroll_stepsmember from scrolling elements, which defaulted scrolling to increments of 1/25 of the total height. For elements with very small overflows, this made scrolling very slow.For scrolling text elements, replace that with
3 * text_size(3 lines/increment). For listboxes, replace it with the button height (1 button/increment).Fixes part of #2845 (slow scroll speeds).