-
Notifications
You must be signed in to change notification settings - Fork 1
Scheduled Notifications for Favorite Eateries #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cassidyxu
wants to merge
28
commits into
master
Choose a base branch
from
scheduled-notifs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b12523c
setup fcm integration with user model
cassidyxu fa75920
Merge branch 'users' into notifications
cassidyxu 366c48c
fix migrations
cassidyxu 59b434b
create scheduled cron job
cassidyxu 1c706f9
Merge branch 'master' into notifications
cassidyxu f5824b9
unify device_token and FCM token logic
cassidyxu 2e6c31e
fix fcm django import
skyeslattery 7ffff33
changes
cassidyxu 68721fe
increase character limit for device token
cassidyxu ac780f8
Merge branch 'notifications' of github.com:cuappdev/eatery-blue-backe…
cassidyxu 5124a08
add migrations
cassidyxu f77c6e1
add device tokens to serializer
skyeslattery 082c9c6
minor fixes
cassidyxu c52c617
add unit tests for eatery event notifs
cassidyxu b77b7c0
small fixes + testing cron job successful
cassidyxu 3c81592
add unit tests for eatery event notifs
cassidyxu ebd4872
small fixes + testing cron job successful
cassidyxu 9573467
Remove Firebase JSON file and add to .gitignore
cassidyxu 78f702c
set up Firestore for notification scheduling
cassidyxu 7dcd66a
small changes
cassidyxu 5a8c945
Integrate Cloud Tasks for eatery notifications
cassidyxu 8b395f4
handle duplicate events/notifications logic
cassidyxu 3f1ada1
handle general "Open" eatery events
cassidyxu c6cb1c5
handle "open" and regular events separately
cassidyxu 8eaadcd
minor fixes
cassidyxu b622e57
handle "General" events
cassidyxu b84d689
handle quota limits with batches
cassidyxu cb17237
clean up comments
cassidyxu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "projects": { | ||
| "default": "eatery-a4ad1" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "functions": [ | ||
| { | ||
| "source": "functions", | ||
| "codebase": "default", | ||
| "ignore": [ | ||
| "node_modules", | ||
| ".git", | ||
| "firebase-debug.log", | ||
| "firebase-debug.*.log", | ||
| "*.local" | ||
| ], | ||
| "predeploy": [ | ||
| "npm --prefix \"$RESOURCE_DIR\" run build" | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| module.exports = { | ||
| root: true, | ||
| env: { | ||
| es6: true, | ||
| node: true, | ||
| }, | ||
| extends: [ | ||
| "eslint:recommended", | ||
| "plugin:import/errors", | ||
| "plugin:import/warnings", | ||
| "plugin:import/typescript", | ||
| "google", | ||
| "plugin:@typescript-eslint/recommended", | ||
| ], | ||
| parser: "@typescript-eslint/parser", | ||
| parserOptions: { | ||
| project: ["tsconfig.json", "tsconfig.dev.json"], | ||
| sourceType: "module", | ||
| }, | ||
| ignorePatterns: [ | ||
| "/lib/**/*", // Ignore built files. | ||
| "/generated/**/*", // Ignore generated files. | ||
| ], | ||
| plugins: [ | ||
| "@typescript-eslint", | ||
| "import", | ||
| ], | ||
| rules: { | ||
| "quotes": ["error", "double"], | ||
| "import/no-unresolved": 0, | ||
| "indent": ["error", 2], | ||
| "max-len": ["error", {"code": 120}], | ||
| "require-jsdoc": "off", | ||
| "no-trailing-spaces": "off", | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Compiled JavaScript files | ||
| lib/**/*.js | ||
| lib/**/*.js.map | ||
|
|
||
| # TypeScript v1 declaration files | ||
| typings/ | ||
|
|
||
| # Node.js dependency directory | ||
| node_modules/ | ||
| *.local |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These RUNs could be combined, but keeping them separate might be better for debugging. @Aayush-Agnihotri ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah what skye said above is true but i think its fine that way it is, it makes it easy to follow and less complicated