Scheduled Notifications for Favorite Eateries #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd into notifications
Contributor
skyeslattery
left a comment
skyeslattery
left a comment
There was a problem hiding this comment.
We're switching auth to use GET instead of google - should we wait until thats merged and then add notification logic in auth routes? otherwise lgtm
| RUN mv ./cron/notify_eatery_events.txt /etc/cron.d/notify_eatery_events | ||
| RUN chmod 0766 manage.py | ||
| RUN crontab /etc/cron.d/update_db | ||
| RUN crontab /etc/cron.d/notify_eatery_events |
Contributor
There was a problem hiding this comment.
These RUNs could be combined, but keeping them separate might be better for debugging. @Aayush-Agnihotri ?
Contributor
There was a problem hiding this comment.
yeah what skye said above is true but i think its fine that way it is, it makes it easy to follow and less complicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Schedule notifications 30 minutes before a user's favorite eateries open or close.
Changes Made
scheduleDailyNotificationsfunction to schedule notifications in Cloud Tasks. These notifications will be sent out at the appropriate time.Test Coverage
Screenshots