fix: pass pre-read content to RegistryClient for WSL compatibility #9739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanevcantwell
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:XL
3 tasks
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 18 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="core/llm/index.ts">
<violation number="1" location="core/llm/index.ts:1124">
P2: Tool prompt overrides are skipped when tools are only defined in the model’s default completionOptions, so per-model overrides never apply to default tools.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
core/llm/index.ts
Outdated
|
|
||
| // Apply per-model tool prompt overrides if configured | ||
| let effectiveTools = options.tools; | ||
| if (this.toolPromptOverrides?.length && options.tools?.length) { |
Contributor
There was a problem hiding this comment.
P2: Tool prompt overrides are skipped when tools are only defined in the model’s default completionOptions, so per-model overrides never apply to default tools.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At core/llm/index.ts, line 1124:
<comment>Tool prompt overrides are skipped when tools are only defined in the model’s default completionOptions, so per-model overrides never apply to default tools.</comment>
<file context>
@@ -1111,8 +1118,28 @@ export abstract class BaseLLM implements ILLM {
+
+ // Apply per-model tool prompt overrides if configured
+ let effectiveTools = options.tools;
+ if (this.toolPromptOverrides?.length && options.tools?.length) {
+ const { tools: overriddenTools, errors } = applyToolOverrides(
+ options.tools,
</file context>
Fixes continuedev#6242, continuedev#7810 When Windows VS Code connects to WSL, workspace files are accessed via vscode-remote:// URIs. Previously, getAllDotContinueDefinitionFiles() correctly read content via ide.readFile(), but loadYaml.ts discarded the content and passed only the URI path to RegistryClient, which then tried to re-read using fs.readFileSync() - failing for remote URIs. Changes: - Add ContentIdentifier type to PackageIdentifier with uriType: "content" - RegistryClient.getContent() returns pre-read content directly - loadYaml.ts passes content instead of file paths for local blocks - Update all code paths to handle the new content case Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
shanevcantwell
force-pushed
the
fix/wsl-path-construction
branch
from
36b953b to
75d9d05
Compare
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.continue/files failing to load when Windows VS Code connects to WSLloadYaml.tsdiscarded pre-read content and passed only URIs toRegistryClient, which triedfs.readFileSync()(fails forvscode-remote://URIs)ContentIdentifiertype to pass pre-read content directly through the loading pipelineFixes #6242, Fixes #7810
Test plan
code --install-extension.continue/docs/test.yamlin WSL workspace🤖 Generated with Claude Code
Continue Tasks
Powered by Continue
Summary by cubic
Fixes WSL config loading by passing pre-read YAML content through the pipeline to avoid fs reads on vscode-remote:// URIs (Fixes #6242, #7810). Improves error messages by using sourceUri when available.
Written for commit a9a9ebb. Summary will update on new commits.