test: adds system tests for performing tardiff operations using the cli tools on test tar files#78
Draft
rmiki-dev wants to merge 1 commit intocontainers:mainfrom
Draft
test: adds system tests for performing tardiff operations using the cli tools on test tar files#78rmiki-dev wants to merge 1 commit intocontainers:mainfrom
rmiki-dev wants to merge 1 commit intocontainers:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request expands the integration test suite for tar-diff and tar-patch by adding scripts for delta paths, fuzzy renames, multi-layer archives, source prefixes, and CLI error handling. It also refactors shared test logic into a new tests/utils.sh file and updates the Makefile to include these tests and improve the clean target. Feedback focuses on improving shell script robustness in the utility file by using local variables, quoting paths, and ensuring POSIX compliance with a trailing newline.
…li tools on test tar files Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New test scripts for multi-old, source-prefix, errors, delta paths and fuzzy matching are added to
testsdirectory, for end-to-end integration testing.A
utils.shfile is also added with reusable helper functions to avoid duplicate code across scripts.