Skip to content

test: system tests for Fedora compatibility #81

Merged
rmiki-dev merged 1 commit intocontainers:mainfrom
rmiki-dev:fedora-system-tests
Apr 22, 2026
Merged

test: system tests for Fedora compatibility #81
rmiki-dev merged 1 commit intocontainers:mainfrom
rmiki-dev:fedora-system-tests

Conversation

@rmiki-dev
Copy link
Copy Markdown
Collaborator

This PR is a sub-issue of the initial System tests PR #78.

Due to cross-platform compatibility issues encountered in the original PR, I am splitting the implementation by platform. This specific PR focuses on stabilizing and enabling the system tests for Fedora builds.

Subsequent PRs will be submitted for macOS and Windows platforms/architectures once this baseline is merged.

Relates to #78

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the existing test suite by extracting common helper functions into a new tests/utils.sh file and significantly expands test coverage with several new integration scripts. These new tests cover various scenarios including delta paths, fuzzy renames, multiple old layers, source prefixes, and CLI error handling. Feedback highlights a potentially dangerous directory deletion in the Makefile, a bug in the sparse file creation logic within the utility script, and a portability improvement for temporary directory creation.

Comment thread Makefile Outdated
Comment thread tests/utils.sh Outdated
Comment thread tests/test-delta-paths.sh Outdated
@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch from 0b30b88 to 951b677 Compare April 15, 2026 15:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.60%. Comparing base (694288b) to head (ec0afd2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   68.94%   75.60%   +6.66%     
==========================================
  Files          10       10              
  Lines        1111     1111              
==========================================
+ Hits          766      840      +74     
+ Misses        232      159      -73     
+ Partials      113      112       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch 2 times, most recently from 2b52a50 to 88a378b Compare April 17, 2026 12:50
Copy link
Copy Markdown
Collaborator

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole makes sense to me, but I think there might be a critical bug in the makefile.

Comment thread Makefile
Copy link
Copy Markdown
Collaborator

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the .gitignore file to include the temporary "test/" directory and the tar-diff/tar-patch executables in the top level directory:

$ git status
git status
On branch pr-81-testing
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	tar-diff
	tar-patch
	test/

Comment thread tests/test-multi-old.sh Outdated
Comment thread tests/test.sh Outdated
Copy link
Copy Markdown
Collaborator

@pcdubs pcdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch from 88a378b to 903b43c Compare April 21, 2026 18:10
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch from 903b43c to ec0afd2 Compare April 21, 2026 18:19
Copy link
Copy Markdown
Collaborator

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rmiki-dev rmiki-dev merged commit afb00d4 into containers:main Apr 22, 2026
10 of 14 checks passed
@rmiki-dev rmiki-dev deleted the fedora-system-tests branch April 23, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants