utils: Clarify that ensure_file, ensure_dir intentionally follow symlinks#737
Merged
cgwalters merged 1 commit intocontainers:mainfrom Mar 20, 2026
Merged
utils: Clarify that ensure_file, ensure_dir intentionally follow symlinks#737cgwalters merged 1 commit intocontainers:mainfrom
cgwalters merged 1 commit intocontainers:mainfrom
Conversation
…inks In containers#733, the issue reporter thought that we'd intended to use lstat() in ensure_file(), because stat() doesn't normally result in S_ISLNK. In fact this was working as intended - we were checking for the one situation where stat() *will* produce S_ISLNK, which is a dangling symlink - but it wasn't as obvious as it could have been. No functional change, comments only. Fixes: containers#733 Signed-off-by: Simon McVittie <smcv@collabora.com>
This was referenced Mar 20, 2026
|
yes, perfect. thx @smcv ! |
cgwalters
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #733, the issue reporter thought that we'd intended to use lstat() in ensure_file(), because stat() doesn't normally result in S_ISLNK. In fact this was working as intended - we were checking for the one situation where stat() will produce S_ISLNK, which is a dangling symlink - but it wasn't as obvious as it could have been.
No functional change, comments only.
Fixes: #733
@dwahdany, if we had already had these comments, would that have avoided #733?