utils: use lstat() instead of stat() in ensure_file()#734
Closed
dwahdany wants to merge 1 commit intocontainers:mainfrom
Closed
utils: use lstat() instead of stat() in ensure_file()#734dwahdany wants to merge 1 commit intocontainers:mainfrom
dwahdany wants to merge 1 commit intocontainers:mainfrom
Conversation
ensure_file() checks !S_ISLNK to reject symlinks as bind-mount destinations, but uses stat() which follows symlinks. Since stat() resolves the symlink before returning, S_ISLNK is never true for valid symlinks, making the check dead code. Use lstat() so the S_ISLNK check works as intended. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dariush Wahdany <86673488+dwahdany@users.noreply.github.com>
dwahdany
force-pushed
the
fix/ensure-file-lstat
branch
from
3abb587 to
ef1ec4d
Compare
Contributor
|
LGTM |
smcv
requested changes
Mar 20, 2026
Collaborator
smcv
left a comment
smcv
left a comment
There was a problem hiding this comment.
This is a behaviour change (backwards compat break) which I don't think is necessarily intended. See #733 (comment).
It wouldn't surprise me if bubblewrap users like flatpak are relying on the ability to mount a regular file onto a symlink, and have it mount onto the target (creating the target as a regular file if the symlink is dangling).
I think we need to discuss whether this is in fact a bug, before fixing it.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #733.
ensure_file()checks!S_ISLNKto reject symlinks as bind-mount destinations, but usesstat()which follows symlinks. Sincestat()resolves the symlink before returning,S_ISLNKis never true for valid symlinks, making the check dead code.Use
lstat()so theS_ISLNKcheck works as intended.