Skip to content

fix: chmod node-pty spawn-helper in postinstall #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorads merged 3 commits into from
Mar 29, 2026
+21 −2
Merged

fix: chmod node-pty spawn-helper in postinstall #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a8c475
fix: chmod node-pty spawn-helper in postinstall
tborys Mar 29, 2026
7056097
chore: fix biome lint/format in postinstall script
connorads Mar 29, 2026
9c105d3
chore: add removal note for node-pty postinstall workaround
connorads Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
"src/pwa/icons/",
"README.md",
"CHANGELOG.md",
"LICENSE"
"LICENSE",
"scripts/postinstall.mjs"
],
"publishConfig": {
"provenance": true
Expand Down Expand Up @@ -55,7 +56,8 @@
"test:pw:chromium": "playwright test --project=chromium-android",
"test:pw:webkit": "playwright test --project=webkit-iphone",
"release": "semantic-release",
"prepublishOnly": "pnpm run lint:ox && pnpm run lint:knip && pnpm run build:dist && pnpm run lint:publint"
"prepublishOnly": "pnpm run lint:ox && pnpm run lint:knip && pnpm run build:dist && pnpm run lint:publint",
"postinstall": "node scripts/postinstall.mjs"
},
"devDependencies": {
"@biomejs/biome": "^1.9.0",
Expand Down
17 changes: 17 additions & 0 deletions scripts/postinstall.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Workaround for microsoft/node-pty#850 — spawn-helper prebuild ships without
// execute permission on macOS, causing "posix_spawnp failed" at runtime.
// Remove this script once node-pty >=1.2.0 stable is released and we upgrade.
import { chmodSync, existsSync } from 'node:fs'
import { createRequire } from 'node:module'
import { dirname, join } from 'node:path'

const require = createRequire(import.meta.url)
try {
const ptyDir = dirname(require.resolve('node-pty/package.json'))
for (const arch of ['darwin-arm64', 'darwin-x64']) {
const helper = join(ptyDir, 'prebuilds', arch, 'spawn-helper')
if (existsSync(helper)) chmodSync(helper, 0o755)
}
} catch {
// node-pty not found, skip
}
Loading