fix: chmod node-pty spawn-helper in postinstall#22
Merged
connorads merged 3 commits intoconnorads:mainfrom Mar 29, 2026
Merged
Conversation
Contributor
Author
|
LOL, don't merge it, sorry about it man, I will take a look... |
tborys
force-pushed
the
fix/node-pty-spawn-helper-permissions
branch
from
9ac3378 to
0a8c475
Compare
Single quotes, tabs, sorted imports to match project conventions.
Link to upstream issue so we know when to delete this.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2026
## [1.0.2](v1.0.1...v1.0.2) (2026-03-29) ### Bug Fixes * posix_spawnp failed on macos ([#22](#22)) ([b971db1](b971db1))
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21
Summary
scripts/postinstall.mjsthat chmods the node-ptyspawn-helperprebuild to be executable after installpackage.jsonto run the postinstall script and include it in published filesProblem
On macOS,
npm install -g remobiinstalls node-pty'sspawn-helperbinary without execute permission (-rw-r--r--). This causesremobi serveto crash immediately withposix_spawnp failed.Fix
A postinstall script resolves the node-pty package location and chmods
spawn-helperfor bothdarwin-arm64anddarwin-x64prebuilds. Silently skips if node-pty is not found.Test plan
npm install -g remobion macOS arm64, verifyremobi servestarts without error+xafter install