🤖 feat: agent system improvements (Ask agent, tooltips, tool configs)

.storybook/mocks/orpc.ts

@@ -184,7 +184,7 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         description: "Create a plan before coding",
         uiSelectable: true,
         subagentRunnable: false,
-        policyBase: "plan",
+        base: "plan",
       },
       {
         id: "exec",
@@ -193,7 +193,6 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         description: "Implement changes in the repository",
         uiSelectable: true,
         subagentRunnable: true,
-        policyBase: "exec",
       },
       {
         id: "compact",
@@ -202,7 +201,6 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         description: "History compaction (internal)",
         uiSelectable: false,
         subagentRunnable: false,
-        policyBase: "compact",
       },
       {
         id: "explore",
@@ -211,7 +209,7 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
         description: "Read-only repository exploration",
         uiSelectable: false,
         subagentRunnable: true,
-        policyBase: "exec",
+        base: "exec",
       },
     ] satisfies AgentDefinitionDescriptor[]);
 
@@ -332,10 +330,11 @@ export function createMockORPCClient(options: MockORPCClientOptions = {}): APICl
           frontmatter: {
             name: descriptor.name,
             description: descriptor.description,
+            base: descriptor.base,
             ui: { selectable: descriptor.uiSelectable },
             subagent: { runnable: descriptor.subagentRunnable },
             ai: descriptor.aiDefaults,
-            policy: { base: descriptor.policyBase, tools: descriptor.toolFilter },
+            tools: descriptor.tools,
           },
           body: "",
         } satisfies AgentDefinitionPackage;

Makefile

@@ -46,6 +46,9 @@ ifeq (,$(filter -j%,$(MAKEFLAGS)))
 MAKEFLAGS += -j
 endif
 
+# Common esbuild flags for CLI API bundle (ESM format for trpc-cli)
+ESBUILD_CLI_FLAGS := --bundle --format=esm --platform=node --target=node20 --outfile=dist/cli/api.mjs --external:zod --external:commander --external:@trpc/server --banner:js='import { createRequire } from "module"; const require = createRequire(import.meta.url);'
+
 # Include formatting rules
 include fmt.mk
 
@@ -139,13 +142,13 @@ dev: node_modules/.installed build-main ## Start development server (Vite + node
 	# https://github.com/oven-sh/bun/issues/18275
 	@MUX_DISABLE_TELEMETRY=$(if $(MUX_ENABLE_TELEMETRY_IN_DEV),,$(or $(MUX_DISABLE_TELEMETRY),1)) NODE_OPTIONS="--max-old-space-size=4096" npm x concurrently -k --raw \
 		"bun x nodemon --watch src --watch tsconfig.main.json --watch tsconfig.json --ext ts,tsx,json --ignore dist --ignore node_modules --exec node scripts/build-main-watch.js" \
-		"npx esbuild src/cli/api.ts --bundle --format=esm --platform=node --target=node20 --outfile=dist/cli/api.mjs --external:zod --external:commander --external:@trpc/server --banner:js='import { createRequire } from \"module\"; const require = createRequire(import.meta.url);' --watch" \
+		"npx esbuild src/cli/api.ts $(ESBUILD_CLI_FLAGS) --watch" \
 		"vite"
 else
 dev: node_modules/.installed build-main build-preload ## Start development server (Vite + tsgo watcher for 10x faster type checking)
 	@MUX_DISABLE_TELEMETRY=$(if $(MUX_ENABLE_TELEMETRY_IN_DEV),,$(or $(MUX_DISABLE_TELEMETRY),1)) bun x concurrently -k \
 		"bun x concurrently \"$(TSGO) -w -p tsconfig.main.json\" \"bun x tsc-alias -w -p tsconfig.main.json\"" \
-		"bun x esbuild src/cli/api.ts --bundle --format=esm --platform=node --target=node20 --outfile=dist/cli/api.mjs --external:zod --external:commander --external:@trpc/server --banner:js='import { createRequire } from \"module\"; const require = createRequire(import.meta.url);' --watch" \
+		"bun x esbuild src/cli/api.ts $(ESBUILD_CLI_FLAGS) --watch" \
 		"vite"
 endif
 
@@ -159,7 +162,7 @@ dev-server: node_modules/.installed build-main ## Start server mode with hot rel
 	@# On Windows, use npm run because bunx doesn't correctly pass arguments
 	@MUX_DISABLE_TELEMETRY=$(if $(MUX_ENABLE_TELEMETRY_IN_DEV),,$(or $(MUX_DISABLE_TELEMETRY),1)) npmx concurrently -k \
 		"npmx nodemon --watch src --watch tsconfig.main.json --watch tsconfig.json --ext ts,tsx,json --ignore dist --ignore node_modules --exec node scripts/build-main-watch.js" \
-		"npx esbuild src/cli/api.ts --bundle --format=esm --platform=node --target=node20 --outfile=dist/cli/api.mjs --external:zod --external:commander --external:@trpc/server --banner:js='import { createRequire } from \"module\"; const require = createRequire(import.meta.url);' --watch" \
+		"npx esbuild src/cli/api.ts $(ESBUILD_CLI_FLAGS) --watch" \
 		"npmx nodemon --watch dist/cli/index.js --watch dist/cli/server.js --delay 500ms --exec \"node dist/cli/index.js server --host $(or $(BACKEND_HOST),localhost) --port $(or $(BACKEND_PORT),3000)\"" \
 		"$(SHELL) -lc \"MUX_VITE_HOST=$(or $(VITE_HOST),127.0.0.1) MUX_VITE_PORT=$(or $(VITE_PORT),5173) VITE_BACKEND_URL=http://$(or $(BACKEND_HOST),localhost):$(or $(BACKEND_PORT),3000) vite\""
 else
@@ -171,7 +174,7 @@ dev-server: node_modules/.installed build-main ## Start server mode with hot rel
 	@echo "For remote access: make dev-server VITE_HOST=0.0.0.0 BACKEND_HOST=0.0.0.0"
 	@MUX_DISABLE_TELEMETRY=$(if $(MUX_ENABLE_TELEMETRY_IN_DEV),,$(or $(MUX_DISABLE_TELEMETRY),1)) bun x concurrently -k \
 		"bun x concurrently \"$(TSGO) -w -p tsconfig.main.json\" \"bun x tsc-alias -w -p tsconfig.main.json\"" \
-		"bun x esbuild src/cli/api.ts --bundle --format=esm --platform=node --target=node20 --outfile=dist/cli/api.mjs --external:zod --external:commander --external:@trpc/server --banner:js='import { createRequire } from \"module\"; const require = createRequire(import.meta.url);' --watch" \
+		"bun x esbuild src/cli/api.ts $(ESBUILD_CLI_FLAGS) --watch" \
 		"bun x nodemon --watch dist/cli/index.js --watch dist/cli/server.js --delay 500ms --exec 'NODE_ENV=development node dist/cli/index.js server --host $(or $(BACKEND_HOST),localhost) --port $(or $(BACKEND_PORT),3000)'" \
 		"MUX_VITE_HOST=$(or $(VITE_HOST),127.0.0.1) MUX_VITE_PORT=$(or $(VITE_PORT),5173) VITE_BACKEND_URL=http://$(or $(BACKEND_HOST),localhost):$(or $(BACKEND_PORT),3000) vite"
 endif
@@ -186,24 +189,20 @@ build: node_modules/.installed src/version.ts build-renderer build-main build-pr
 
 build-main: node_modules/.installed dist/cli/index.js dist/cli/api.mjs ## Build main process
 
-dist/cli/index.js: src/cli/index.ts src/desktop/main.ts src/cli/server.ts src/version.ts tsconfig.main.json tsconfig.json $(TS_SOURCES)
+BUILTIN_AGENTS_GENERATED := src/node/services/agentDefinitions/builtInAgentContent.generated.ts
+
+$(BUILTIN_AGENTS_GENERATED): src/node/builtinAgents/*.md scripts/generate-builtin-agents.sh
+	@./scripts/generate-builtin-agents.sh
+
+dist/cli/index.js: src/cli/index.ts src/desktop/main.ts src/cli/server.ts src/version.ts tsconfig.main.json tsconfig.json $(TS_SOURCES) $(BUILTIN_AGENTS_GENERATED)
 	@echo "Building main process..."
 	@NODE_ENV=production $(TSGO) -p tsconfig.main.json
 	@NODE_ENV=production bun x tsc-alias -p tsconfig.main.json
 
 # Build API CLI as ESM bundle (trpc-cli requires ESM with top-level await)
 dist/cli/api.mjs: src/cli/api.ts src/cli/proxifyOrpc.ts $(TS_SOURCES)
 	@echo "Building API CLI (ESM)..."
-	@bun x esbuild src/cli/api.ts \
-		--bundle \
-		--format=esm \
-		--platform=node \
-		--target=node20 \
-		--outfile=dist/cli/api.mjs \
-		--banner:js='import { createRequire } from "module"; const require = createRequire(import.meta.url);' \
-		--external:zod \
-		--external:commander \
-		--external:@trpc/server
+	@bun x esbuild src/cli/api.ts $(ESBUILD_CLI_FLAGS)
 
 build-preload: node_modules/.installed dist/preload.js ## Build preload script