🤖 feat: improve agent definitions with markdown files and docs generation #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…tion - Convert built-in agents to markdown files (src/node/builtinAgents/*.md) - exec.md, plan.md, compact.md, explore.md - Same format as user-defined agents, serving as examples - Add `ui.disabled` support for completely hiding agents - Useful for disabling built-in agents without replacing them - Extend gen_docs.ts to auto-generate built-in agents section - Syncs docs/agents.mdx from src/node/builtinAgents/*.md - Shows each agent in an expandable accordion - Improve docs/agents.mdx with: - Quick start guide - Frontmatter schema reference - Disabling built-ins documentation - Example custom agents (Security Audit, Documentation) --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
ammar-agent
force-pushed
the
modes-mf56
branch
from
f59658e to
33a203d
Compare
ammar-agent
changed the title
- Add copy step in Makefile to copy src/node/builtinAgents/*.md to dist/builtinAgents/ - Add dist/**/*.md to package.json files array - Path resolution works in both dev and prod since __dirname + ../../builtinAgents resolves correctly
The API CLI uses ESM (.mjs) where __dirname is not available, and import.meta.url doesn't work with the main process TypeScript config. Keep built-ins hardcoded for runtime reliability while maintaining .md files for documentation generation. - builtInAgentDefinitions.ts: hardcoded agents (ESM + CJS compatible) - src/node/builtinAgents/*.md: source files for docs generation - gen_docs.ts: generates docs/agents.mdx from .md files - dist/builtinAgents/*.md: copied during build (for reference, not runtime)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the agent definitions system by:
Converting built-in agents to markdown files - Built-ins now use the same format as user-defined agents, serving as authentic examples. Files live in
src/node/builtinAgents/*.md.Adding
ui.disabledsupport - Users can now completely hide agents (including built-ins) by creating a file withui.disabled: true. This is useful for disabling built-in agents without replacing them.Auto-generating built-in agents in docs - Extended
scripts/gen_docs.tsto sync the built-in agents section ofdocs/agents.mdxfrom the source markdown files. Single source of truth.Improved agents documentation - Enhanced
docs/agents.mdxwith:Files Changed
src/node/builtinAgents/*.md- New built-in agent definitionssrc/node/services/agentDefinitions/builtInAgentDefinitions.ts- Load from disksrc/node/services/agentDefinitions/agentDefinitionsService.ts- Handledisabledfilteringsrc/common/orpc/schemas/agentDefinition.ts- Adddisabledto schemascripts/gen_docs.ts- Auto-generate built-in agents sectiondocs/agents.mdx- Improved documentationGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high