Skip to content

fix: allow 'mixed' invoice type in DB constraint #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coder-contrib-bot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow 'mixed' invoice type in DB constraint #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
130576e
fix: allow 'mixed' invoice type in DB constraint and backend validation
coder-contrib-bot May 25, 2026
d4a7561
fix: update schema.sql constraint for mixed invoice type
coder-contrib-bot May 25, 2026
2f5560d
fix: restore full schema.sql with mixed invoice type constraint
coder-contrib-bot May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions backend/app/services/sales_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ def get_invoice(self, invoice_id: int) -> SalesInvoice:
def create_invoice(self, data: SalesInvoiceCreate) -> SalesInvoice:
with transaction(self.db):
# --- VALIDATION ---
if data.invoice_type == "credit" and not data.customer_id:
raise ValidationError("Credit invoices require a customer")
if data.invoice_type in ("credit", "mixed") and not data.customer_id:
raise ValidationError("Credit and mixed invoices require a customer")

total_amount = sum(item.total_price for item in data.items)

if data.invoice_type == "credit" and data.customer_id:
if data.invoice_type in ("credit", "mixed") and data.customer_id:
self.validator.validate_credit_limit(data.customer_id, total_amount)

for item_data in data.items:
Expand Down Expand Up @@ -96,10 +96,10 @@ def create_invoice(self, data: SalesInvoiceCreate) -> SalesInvoice:
total_amount=total_amount,
cogs=sum(item.sold_quantity * item.cost_at_sale for item in data.items),
cash_received=data.paid_amount,
is_credit=(data.invoice_type == "credit"),
is_credit=(data.invoice_type in ("credit", "mixed")),
)

if data.invoice_type == "credit" and data.customer_id:
if data.invoice_type in ("credit", "mixed") and data.customer_id and remaining > 0:
customer = self.customer_repo.get_by_id(data.customer_id)
self.customer_repo.update_balance(customer, remaining)

Expand Down
6 changes: 6 additions & 0 deletions database/fix_mixed_invoice_type.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
-- Fix: Allow 'mixed' invoice type in the check constraint
-- The frontend supports 'mixed' invoices (part cash, part credit) but the DB constraint only allowed 'cash' or 'credit'

ALTER TABLE sales_invoices DROP CONSTRAINT chk_credit_requires_customer;
ALTER TABLE sales_invoices ADD CONSTRAINT chk_credit_requires_customer
CHECK (invoice_type = 'cash' OR (invoice_type IN ('credit', 'mixed') AND customer_id IS NOT NULL));
2 changes: 1 addition & 1 deletion database/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ CREATE TABLE sales_invoices (
warehouse_id INTEGER NOT NULL REFERENCES warehouses(warehouse_id),
warehouse_notes TEXT,
notes TEXT,
CONSTRAINT chk_credit_requires_customer CHECK (invoice_type = 'cash' OR (invoice_type = 'credit' AND customer_id IS NOT NULL))
CONSTRAINT chk_credit_requires_customer CHECK (invoice_type = 'cash' OR (invoice_type IN ('credit', 'mixed') AND customer_id IS NOT NULL))
);

-- 10. Sales Invoice Items
Expand Down