fix: allow 'mixed' invoice type in DB constraint#4
Open
coder-contrib-bot wants to merge 3 commits into
Open
Conversation
The frontend supports 'mixed' invoices (part cash, part credit) but the database check constraint `chk_credit_requires_customer` only accepted 'cash' or 'credit', causing 500 errors on mixed invoice creation. Changes: - Update DB constraint to allow 'mixed' type (requires customer_id) - Update backend validation to handle 'mixed' like 'credit' - Update credit limit check to apply to mixed invoices - Update customer balance tracking for mixed invoices - Update ledger recording for mixed invoices - Add migration SQL for live databases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chk_credit_requires_customerDB constraint to allow'mixed'invoice type (part cash, part credit)'mixed'like'credit'database/fix_mixed_invoice_type.sql) for live databasesRoot Cause
The frontend supports a "Mixed" invoice type (part cash, part credit), but the database check constraint only accepted
'cash'or'credit'. When a user created a mixed invoice, PostgreSQL rejected the insert with:Changes
database/schema.sql'mixed'database/fix_mixed_invoice_type.sqlbackend/app/services/sales_service.py'mixed'in validation, credit limit, ledger, and balance updatesAuthor
🤖 Generated with Claude Code