[pull] main from TryGhost:main #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This test-only change should have no user impact.*
) ref https://github.com/TryGhost/Ghost/actions/runs/21494158108/job/61924761703 One of the newsletter tests is [flaky in CI][0]. I think this is because app settings are loading and we redirect away before they do. The old logic was, roughly: redirect if newsletters are disabled *or* if app settings are still loading. The new logic is: redirect if newsletters are disabled. Don't redirect if app settings are still loading. I'm not certain this will fix CI flakiness--I can't reproduce locally--but I think this is an improvement anyway. [0]: https://github.com/TryGhost/Ghost/actions/runs/21494158108/job/61924761703 --------- Co-authored-by: Chris Raible <chris@ghost.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )