-
Notifications
You must be signed in to change notification settings - Fork 15
feat: implement scoreTargets configuration for all plugins #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 4afb131
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 58583f9 with previous commit b05dd6e. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 6 audits regressed, 14 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
588 other audits are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature!! One small improvement/nitpick popped up on how to mock functions, the rest is fine for me.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for adjusting the mock code!
Closes #713 closes #721
This PR finalizes
scoreTarget/scoreTargetsfeature implementation, allowing users to configure threshold values for audits across all plugins.Changes
perfectScoreThresholdwithscoreTargetsin the coverage pluginscoreTargetssupport to all plugins: ESLint, Lighthouse, JS Packages, TypeScript, and JSDocBreaking change
Coverage plugin:
perfectScoreThreshold→scoreTargetsUsage