test: remove redundant test cases

Author: hanna-skryl

packages/plugin-coverage/src/lib/coverage-plugin.unit.test.ts

@@ -83,28 +83,13 @@ describe('coveragePlugin', () => {
   });
 
   it('should pass scoreTargets to PluginConfig when provided', async () => {
-    const pluginConfig = await coveragePlugin({
-      reports: [LCOV_PATH],
-      scoreTargets: 0.8,
-    });
-
-    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
-    expect(pluginConfig.scoreTargets).toBe(0.8);
-  });
-
-  it('should pass object scoreTargets to PluginConfig', async () => {
     const scoreTargets = { 'function-coverage': 0.9, 'line-coverage': 0.8 };
     const pluginConfig = await coveragePlugin({
       reports: [LCOV_PATH],
       scoreTargets,
     });
 
+    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
     expect(pluginConfig.scoreTargets).toStrictEqual(scoreTargets);
   });
-
-  it('should not have scoreTargets when not provided', async () => {
-    const pluginConfig = await coveragePlugin({ reports: [LCOV_PATH] });
-
-    expect(pluginConfig.scoreTargets).toBeUndefined();
-  });
 });

packages/plugin-eslint/src/lib/eslint-plugin.unit.test.ts

@@ -7,28 +7,12 @@ describe('eslintPlugin', () => {
 
   beforeAll(() => {
     listAuditsAndGroupsSpy.mockResolvedValue({
-      audits: [
-        { slug: 'type-safety', title: 'Type Safety' },
-        { slug: 'no-empty', title: 'Disallow empty block statements' },
-      ],
+      audits: [{ slug: 'type-safety', title: 'Type Safety' }],
       groups: [],
     });
   });
 
   it('should pass scoreTargets to PluginConfig when provided', async () => {
-    const pluginConfig = await eslintPlugin(
-      {
-        eslintrc: 'eslint.config.js',
-        patterns: ['src/**/*.js'],
-      },
-      { scoreTargets: 0.8 },
-    );
-
-    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
-    expect(pluginConfig.scoreTargets).toBe(0.8);
-  });
-
-  it('should pass object scoreTargets to PluginConfig', async () => {
     const scoreTargets = { 'type-safety': 0.9 };
     const pluginConfig = await eslintPlugin(
       {
@@ -41,13 +25,4 @@ describe('eslintPlugin', () => {
     expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
     expect(pluginConfig.scoreTargets).toStrictEqual(scoreTargets);
   });
-
-  it('should not have scoreTargets when not provided', async () => {
-    const pluginConfig = await eslintPlugin({
-      eslintrc: 'eslint.config.js',
-      patterns: ['src/**/*.js'],
-    });
-
-    expect(pluginConfig.scoreTargets).toBeUndefined();
-  });
 });

packages/plugin-js-packages/src/lib/js-packages-plugin.unit.test.ts

@@ -186,16 +186,6 @@ describe('jsPackagesPlugin', () => {
   });
 
   it('should pass scoreTargets to PluginConfig when provided', async () => {
-    const pluginConfig = await jsPackagesPlugin({
-      packageManager: 'npm',
-      scoreTargets: 0.8,
-    });
-
-    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
-    expect(pluginConfig.scoreTargets).toBe(0.8);
-  });
-
-  it('should pass object scoreTargets to PluginConfig', async () => {
     const scoreTargets = { 'npm-outdated-dev': 0.9 };
     const pluginConfig = await jsPackagesPlugin({
       packageManager: 'npm',
@@ -205,10 +195,4 @@ describe('jsPackagesPlugin', () => {
     expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
     expect(pluginConfig.scoreTargets).toStrictEqual(scoreTargets);
   });
-
-  it('should not have scoreTargets when not provided', async () => {
-    const pluginConfig = await jsPackagesPlugin({ packageManager: 'npm' });
-
-    expect(pluginConfig.scoreTargets).toBeUndefined();
-  });
 });

packages/plugin-jsdocs/src/lib/jsdocs-plugin.unit.test.ts

@@ -87,16 +87,6 @@ describe('jsDocsPlugin', () => {
   });
 
   it('should pass scoreTargets to PluginConfig when provided', () => {
-    const pluginConfig = jsDocsPlugin({
-      patterns: ['src/**/*.ts'],
-      scoreTargets: 0.9,
-    });
-
-    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
-    expect(pluginConfig.scoreTargets).toBe(0.9);
-  });
-
-  it('should pass object scoreTargets to PluginConfig', () => {
     const scoreTargets = { 'functions-coverage': 0.9 };
     const pluginConfig = jsDocsPlugin({
       patterns: ['src/**/*.ts'],
@@ -106,12 +96,4 @@ describe('jsDocsPlugin', () => {
     expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
     expect(pluginConfig.scoreTargets).toStrictEqual(scoreTargets);
   });
-
-  it('should not have scoreTargets when not provided', () => {
-    expect(
-      jsDocsPlugin({
-        patterns: ['src/**/*.ts'],
-      }).scoreTargets,
-    ).toBeUndefined();
-  });
 });

packages/plugin-lighthouse/src/lib/lighthouse-plugin.unit.test.ts

@@ -122,15 +122,6 @@ describe('lighthousePlugin-config-object', () => {
   });
 
   it('should pass scoreTargets to PluginConfig when provided', () => {
-    const pluginConfig = lighthousePlugin('https://code-pushup-portal.com', {
-      scoreTargets: 0.8,
-    });
-
-    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
-    expect(pluginConfig.scoreTargets).toBe(0.8);
-  });
-
-  it('should pass object scoreTargets to PluginConfig', () => {
     const scoreTargets = { 'first-contentful-paint': 0.9 };
     const pluginConfig = lighthousePlugin('https://code-pushup-portal.com', {
       scoreTargets,
@@ -139,10 +130,4 @@ describe('lighthousePlugin-config-object', () => {
     expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
     expect(pluginConfig.scoreTargets).toStrictEqual(scoreTargets);
   });
-
-  it('should not have scoreTargets when not provided', () => {
-    expect(
-      lighthousePlugin('https://code-pushup-portal.com').scoreTargets,
-    ).toBeUndefined();
-  });
 });

packages/plugin-typescript/src/lib/typescript-plugin.unit.test.ts

@@ -39,15 +39,6 @@ describe('typescriptPlugin-config-object', () => {
   });
 
   it('should pass scoreTargets to PluginConfig when provided', async () => {
-    const pluginConfig = await typescriptPlugin({
-      scoreTargets: 0.8,
-    });
-
-    expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
-    expect(pluginConfig.scoreTargets).toBe(0.8);
-  });
-
-  it('should pass object scoreTargets to PluginConfig', async () => {
     const scoreTargets = { 'no-implicit-any-errors': 0.9 };
     const pluginConfig = await typescriptPlugin({
       scoreTargets,
@@ -56,10 +47,4 @@ describe('typescriptPlugin-config-object', () => {
     expect(() => pluginConfigSchema.parse(pluginConfig)).not.toThrow();
     expect(pluginConfig.scoreTargets).toStrictEqual(scoreTargets);
   });
-
-  it('should not have scoreTargets when not provided', async () => {
-    const pluginConfig = await typescriptPlugin();
-
-    expect(pluginConfig.scoreTargets).toBeUndefined();
-  });
 });