-
Notifications
You must be signed in to change notification settings - Fork 15
feat: implement scoreTarget for categories #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c98d06a with previous commit 2ae961a. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👍 6 audits improved, 👎 1 audit regressed, 16 audits changed without impacting score🗃️ Groups
19 other groups are unchanged. 🛡️ Audits
587 other audits are unchanged. |
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Also left a comment to remove deprecated text.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #713
This PR replaces
isBinary: booleanwithscoreTarget: numberinCategoryConfigfor flexible pass/fail thresholds.isBinarywithscoreTargetin category schematargetScoreIcontoscoreTargetIconfor consistencymergemethod withextendinCategoryConfig