Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

Part of #713

This PR replaces isBinary: boolean with scoreTarget: number in CategoryConfig for flexible pass/fail thresholds.

  • Replace isBinary with scoreTarget in category schema
  • Add backward compatibility for Portal API
  • Rename targetScoreIcon to scoreTargetIcon for consistency
  • Update tests and documentation
  • Replace deprecated Zod merge method with extend in CategoryConfig

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 18, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1072

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1072

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1072

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1072

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1072

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1072

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1072

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1072

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1072

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1072

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1072

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1072

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1072

commit: 9efb81c

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c98d06a with previous commit 2ae961a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 30 🔴 32 ↑ +2.4
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 2 groups improved, 👍 6 audits improved, 👎 1 audit regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 30 🔴 32 ↑ +2.4
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 610 ms 🟩 Root document took 450 ms ↓ −26.2 %
Lighthouse Properly size images 🟨 Potential savings of 5 KiB 🟩 0  −∞ %
Lighthouse Speed Index 🟥 9.6 s 🟥 7.7 s ↓ −20.3 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.1 s ↓ −9.6 %
Lighthouse Time to Interactive 🟥 20.7 s 🟥 19.0 s ↓ −8.4 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↑ +0.1 %
Code coverage Line coverage 🟨 87.1 % 🟨 87.1 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,707 KiB 🟨 Total size was 2,675 KiB ↓ −1.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 30 resources found ↓ −0.7 %
Lighthouse JavaScript execution time 🟥 11.6 s 🟥 8.4 s ↓ −27.7 %
Lighthouse Minimizes main-thread work 🟥 22.3 s 🟥 19.8 s ↓ −11.3 %
Lighthouse Total Blocking Time 🟥 7,670 ms 🟥 5,910 ms ↓ −23 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −8.3 %
Lighthouse Max Potential First Input Delay 🟥 2,400 ms 🟥 1,610 ms ↓ −33.2 %
Lighthouse Server Backend Latencies 🟩 1,690 ms 🟩 1,370 ms ↓ −19 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 549 KiB 🟥 Potential savings of 603 KiB ↑ +34.8 %
Lighthouse Largest Contentful Paint 🟥 13.2 s 🟥 13.0 s ↓ −1.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 92 KiB 🟥 Potential savings of 90 KiB ↑ +34.8 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 10 ms ↓ −84.8 %
Lighthouse Avoids an excessive DOM size 🟥 2,329 elements 🟥 2,299 elements ↓ −1.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 102 KiB 🟥 Potential savings of 113 KiB ↑ +1.6 %
JS Packages Outdated NPM dev dependencies. 🟨 55 outdated package versions (30 major, 21 minor, 4 patch) 🟨 56 outdated package versions (30 major, 21 minor, 5 patch) ↑ +1.8 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0.001 ↑ +∞ %

587 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review August 18, 2025 21:31
@hanna-skryl hanna-skryl requested a review from BioPhoton as a code owner August 18, 2025 21:31
@hanna-skryl hanna-skryl requested a review from matejchalk August 18, 2025 21:32
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Also left a comment to remove deprecated text.

matejchalk
matejchalk previously approved these changes Aug 19, 2025
@BioPhoton BioPhoton self-requested a review August 19, 2025 15:19
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanna-skryl hanna-skryl merged commit 44e4934 into main Aug 19, 2025
17 checks passed
@hanna-skryl hanna-skryl deleted the categories-score-target branch August 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants