Skip to content

Commit 9efb81c

Browse files
committed
refactor: remove PWA mentions
1 parent ad1bf5d commit 9efb81c

File tree

4 files changed

+5
-33
lines changed

4 files changed

+5
-33
lines changed

packages/plugin-lighthouse/README.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,6 @@ export default {
8686
title: 'SEO',
8787
refs: [lighthouseGroupRef('seo')],
8888
},
89-
{
90-
slug: 'pwa',
91-
scoreTarget: 1,
92-
title: 'PWA',
93-
refs: [lighthouseGroupRef('pwa')],
94-
},
9589
],
9690
};
9791
```
@@ -108,10 +102,10 @@ export default {
108102
// ...
109103
categories: [
110104
{
111-
slug: 'pwa',
112-
scoreTarget: 1,
113-
title: 'PWA',
114-
refs: [lighthouseAuditRef('installable-manifest', 2), lighthouseAuditRef('splash-screen', 1), lighthouseAuditRef('themed-omnibox', 1), lighthouseAuditRef('content-width', 1), lighthouseAuditRef('themed-omnibox', 2), lighthouseAuditRef('viewport', 2), lighthouseAuditRef('maskable-icon', 1), lighthouseAuditRef('pwa-cross-browser', 0), lighthouseAuditRef('pwa-page-transitions', 0), lighthouseAuditRef('pwa-each-page-has-url', 0)],
105+
slug: 'core-web-vitals',
106+
title: 'Core Web Vitals',
107+
scoreTarget: 0.9,
108+
refs: [lighthouseAuditRef('largest-contentful-paint', 3), lighthouseAuditRef('first-input-delay', 2), lighthouseAuditRef('cumulative-layout-shift', 2), lighthouseAuditRef('first-contentful-paint', 1)],
115109
},
116110
],
117111
};

packages/plugin-lighthouse/src/lib/constants.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export const LIGHTHOUSE_GROUP_SLUGS = [
1616
'accessibility',
1717
'best-practices',
1818
'seo',
19-
'pwa',
2019
] as const;
2120

2221
export const SINGLE_URL_THRESHOLD = 1;

packages/utils/src/lib/reports/__snapshots__/generate-md-report.unit.test.ts.snap

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ exports[`generateMdReport > should render complete md report 1`] = `
7474
| :-------------------------- | :----------: | :-------: |
7575
| [Performance](#performance) | 🟡 **61** | 2 |
7676
| [SEO](#seo) | 🟢 **100** ✅ | 1 |
77-
| [PWA](#pwa) | 🔴 **0** ❌ | 1 |
7877
7978
## 🏷 Categories
8079
@@ -92,12 +91,6 @@ exports[`generateMdReport > should render complete md report 1`] = `
9291
9392
- 🟥 [Website is crawlable](#website-is-crawlable-lighthouse) (_Lighthouse_) - **0**
9493
95-
### PWA
96-
97-
🔴 Score: **0** ❌
98-
99-
- 🟩 [Splash Screen](#splash-screen-lighthouse) (_Lighthouse_) - **1**
100-
10194
## 🛡️ Audits
10295
10396
### Largest Contentful Paint (Lighthouse)
@@ -175,7 +168,7 @@ Report was created by [Code PushUp](https://github.com/code-pushup/cli#readme) o
175168
176169
| Commit | Version | Duration | Plugins | Categories | Audits |
177170
| :----------------------------------------------------------- | :------: | -------: | :-----: | :--------: | :----: |
178-
| ci: update action (535b8e9e557336618a764f3fa45609d224a62837) | \`v1.0.0\` | 42.36 s | 2 | 3 | 5 |
171+
| ci: update action (535b8e9e557336618a764f3fa45609d224a62837) | \`v1.0.0\` | 42.36 s | 2 | 2 | 5 |
179172
180173
---
181174

packages/utils/src/lib/reports/generate-md-report.unit.test.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -912,20 +912,6 @@ module.exports = {
912912
},
913913
],
914914
},
915-
{
916-
title: 'PWA',
917-
slug: 'pwa',
918-
score: 0,
919-
scoreTarget: 1,
920-
refs: [
921-
{
922-
slug: 'splash-screen',
923-
plugin: 'lighthouse',
924-
type: 'audit',
925-
weight: 1,
926-
},
927-
],
928-
},
929915
],
930916
}),
931917
).toMatchSnapshot();

0 commit comments

Comments
 (0)