Skip to content

chore: Fix border radius bug on segmented-control #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
at-susie wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −4
Open

chore: Fix border radius bug on segmented-control #4398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd9e344
chore: Fix border radius bug on segmented-control
at-susie Mar 30, 2026
ce85ad6
Merge branch 'main' into feat/segment-fix
at-susie Mar 30, 2026
7dff4f9
Merge branch 'main' into feat/segment-fix
at-susie Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pages/theming/themed-stroke-width.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
InputProps,
KeyValuePairs,
Link,
SegmentedControl,
Select,
SelectProps,
SpaceBetween,
Expand Down Expand Up @@ -72,6 +73,7 @@ export default function ThemedStrokeWidthPage() {
borderWidthIconMedium: strokeMedium ? `${strokeMedium}px` : '1px',
borderWidthIconBig: strokeBig ? `${strokeBig}px` : '1.5px',
borderWidthIconLarge: strokeLarge ? `${strokeLarge}px` : '2px',
borderRadiusButton: '8px',
},
};

Expand All @@ -84,6 +86,8 @@ export default function ThemedStrokeWidthPage() {
return reset;
}, [themed, strokeSmall, strokeNormal, strokeMedium, strokeBig, strokeLarge]);

const [selectedId, setSelectedId] = React.useState('seg-1');

return (
<div style={{ padding: 15 }}>
<h1>Themed icon stroke width</h1>
Expand Down Expand Up @@ -220,6 +224,17 @@ export default function ThemedStrokeWidthPage() {
</Button>
</div>

<SegmentedControl
selectedId={selectedId}
onChange={({ detail }) => setSelectedId(detail.selectedId)}
label="Default segmented control"
options={[
{ text: 'Segment 1', id: 'seg-1' },
{ text: 'Segment 2', id: 'seg-2' },
{ text: 'Segment 3', id: 'seg-3' },
]}
/>

<div>
<Link external={true} href="https://example.com/" variant="primary">
Learn more
Expand Down
9 changes: 5 additions & 4 deletions src/segmented-control/segment.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ $selected-background: var(#{custom-props.$styleBackgroundActive}, awsui.$color-b
$selected-color: var(#{custom-props.$styleColorActive}, awsui.$color-text-segment-active);
$segment-gap: awsui.$space-static-xxs;
$segment-divider-width: 1px;
$segment-radius: calc(awsui.$border-radius-button - 3px);

.segment {
@include styles.font-body-m;
Expand All @@ -34,10 +35,10 @@ $segment-divider-width: 1px;
color: $default-color;
overflow: visible;

border-start-start-radius: awsui.$border-radius-button;
border-start-end-radius: awsui.$border-radius-button;
border-end-start-radius: awsui.$border-radius-button;
border-end-end-radius: awsui.$border-radius-button;
border-start-start-radius: $segment-radius;
border-start-end-radius: $segment-radius;
border-end-start-radius: $segment-radius;
border-end-end-radius: $segment-radius;

position: relative;
block-size: calc(100% - $segment-gap);
Expand Down
Loading