Skip to content

chore: Fix border radius bug on segmented-control#4398

Open
at-susie wants to merge 2 commits intomainfrom
feat/segment-fix
Open

chore: Fix border radius bug on segmented-control#4398
at-susie wants to merge 2 commits intomainfrom
feat/segment-fix

Conversation

@at-susie
Copy link
Copy Markdown
Member

@at-susie at-susie commented Mar 30, 2026

Description

Fixes a bug in the segmented control’s border-radius styling. Previously, each segment used the same radius as borderRadiusButton. Because the inner segments are shorter than the button height, customizing borderRadiusButton could result in visibly misaligned corner radii compared to the outer border (see attached image).

segmented-fix

This change does not affect the default styling, but improves visual consistency when borderRadiusButton is customized.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@at-susie at-susie marked this pull request as ready for review March 30, 2026 17:11
@at-susie at-susie requested a review from a team as a code owner March 30, 2026 17:11
@at-susie at-susie requested review from NathanZlion and removed request for a team March 30, 2026 17:11
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (a6cdcd0) to head (ce85ad6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4398   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         909      909           
  Lines       26637    26637           
  Branches     9614     9615    +1     
=======================================
  Hits        25958    25958           
+ Misses        673      636   -37     
- Partials        6       43   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant