Skip to content

Fixes _BaseMinionPoolProvider base provider class #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claudiubelu wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Fixes _BaseMinionPoolProvider base provider class #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions coriolis/providers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,6 +1317,7 @@ def attach_volumes_to_minion(
ctxt: context.RequestContext,
connection_info: dict,
minion_properties: dict,
minion_connection_info: dict,
volumes_info: list[dict],
) -> dict:
"""Attach volumes to minion instance.
Expand All @@ -1328,6 +1329,8 @@ def attach_volumes_to_minion(
"minion_provider_properties".
:param volumes_info: provider specific list of volumes, conforming
to volumes_info_schema.json
:param minion_connection_info: minion connection info returned by
"create_minion"
:returns: a dict containing the following fields
* minion_properties - updated minion properties
* volumes_info - updated volume info, specifying the attachment
Expand All @@ -1347,6 +1350,7 @@ def detach_volumes_from_minion(
ctxt: context.RequestContext,
connection_info: dict,
minion_properties: dict,
minion_connection_info: dict,
volumes_info: list[dict],
):
"""Detach volumes from minion instance.
Expand All @@ -1356,8 +1360,14 @@ def detach_volumes_from_minion(
:param minion_properties: provider specific properties returned by
"create_minion" through
"minion_provider_properties".
:param minion_connection_info: minion connection info returned by
"create_minion"
:param volumes_info: provider specific list of volumes, conforming
to volumes_info_schema.json

:returns: a dict containing the following fields
* minion_properties - updated minion properties
* volumes_info - updated volume info.
"""
pass

Expand Down
Loading