Fixes _BaseMinionPoolProvider base provider class#425
Open
claudiubelu wants to merge 1 commit intocloudbase:masterfrom
Open
Fixes _BaseMinionPoolProvider base provider class#425claudiubelu wants to merge 1 commit intocloudbase:masterfrom
claudiubelu wants to merge 1 commit intocloudbase:masterfrom
Conversation
`coriolis.tasks.minion_pool_tasks._BaseVolumesMinionMachineAttachmentTask._run`, which calls the `attach_volumes_to_minion` and `detach_volumes_from_minion` passes in 5 arguments, not 4. The base class signatures should be amended, to better reflect their actual usage. In the same `_run` call, the called method's output is verified, and it verifies that the fields "volumes_info" and "minion_properties" are present in the result. The `detach_volumes_from_minion` does not mention that it should return this information. The docstring is now updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coriolis.tasks.minion_pool_tasks._BaseVolumesMinionMachineAttachmentTask._run, which calls theattach_volumes_to_minionanddetach_volumes_from_minionpasses in 5 arguments, not 4. The base class signatures should be amended, to better reflect their actual usage.In the same
_runcall, the called method's output is verified, and it verifies that the fields"volumes_info"and"minion_properties"are present in the result. Thedetach_volumes_from_miniondoes not mention that it should return this information. The docstring is now updated.