Skip to content

Fix a flaky issue with task percentage not stored in DB #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabi200123 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Fix a flaky issue with task percentage not stored in DB #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion coriolis/conductor/rpc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,10 @@ def add_task_progress_update(
def update_task_progress_update(
self, ctxt, task_id, progress_update_index, new_current_step,
new_total_steps=None, new_message=None):
self._cast(
# Must use synchronous RPC: EventManager advances last_perc only after
Copy link
Copy Markdown
Member

@petrutlucian94 petrutlucian94 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't a synchronous RPC call slow down the transfer? There are quite a few progress updates that will now have to wait for the conductor.

Copy link
Copy Markdown
Contributor Author

@fabi200123 fabi200123 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the Daniel's question as well.
Asked Emilian to do a test, and there was no significant difference regarding time.

Copy link
Copy Markdown
Member

@petrutlucian94 petrutlucian94 May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"no significant difference" doesn't tell us much. When talking about performance, we need actual numbers. Ideally some profiler data.

The performance impact may be more significant if the conductor is under load, e.g. having 10-20 concurrent migrations.

# this returns; fire-and-forget can lose the final update while state
# has already moved on, preventing any retry.
return self._call(
ctxt, 'update_task_progress_update', task_id=task_id,
progress_update_index=progress_update_index,
new_current_step=new_current_step,
Expand Down
3 changes: 1 addition & 2 deletions coriolis/tests/conductor/rpc/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,7 @@ def test_update_task_progress_update(self):
"new_total_steps": None,
"new_message": None
}
self._test(self.client.update_task_progress_update, args,
rpc_op='_cast')
self._test(self.client.update_task_progress_update, args)

def test_create_transfer_schedule(self):
args = {
Expand Down
Loading