Fix a flaky issue with task percentage not stored in DB#421
Open
fabi200123 wants to merge 1 commit intocloudbase:masterfrom
Open
Fix a flaky issue with task percentage not stored in DB#421fabi200123 wants to merge 1 commit intocloudbase:masterfrom
fabi200123 wants to merge 1 commit intocloudbase:masterfrom
Conversation
| self, ctxt, task_id, progress_update_index, new_current_step, | ||
| new_total_steps=None, new_message=None): | ||
| self._cast( | ||
| # Must use synchronous RPC: EventManager advances last_perc only after |
Member
There was a problem hiding this comment.
Won't a synchronous RPC call slow down the transfer? There are quite a few progress updates that will now have to wait for the conductor.
Contributor
Author
There was a problem hiding this comment.
That was the Daniel's question as well.
Asked Emilian to do a test, and there was no significant difference regarding time.
Member
There was a problem hiding this comment.
"no significant difference" doesn't tell us much. When talking about performance, we need actual numbers. Ideally some profiler data.
The performance impact may be more significant if the conductor is under load, e.g. having 10-20 concurrent migrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like there is a flaky issue with the percentage for Replicate Disks.
The final steps for replication are not stored in the DB and the UI doesn't display the 100% for disk replication. The worker reaches the 100%, but the 100% is never stored in the DB.
This issue seems to come from the
self._castfromupdate_task_progress_update.NOTE: Changing it to
_callseems to fix the issue, but the whole issue is hard to replicate.