-
Notifications
You must be signed in to change notification settings - Fork 1
Plot more observation vars #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for plotting additional observation variables (pressure, temperature, relative humidity) in vertical profile analyses, along with a new feature to load experiments from external URLs.
Key changes:
- Extended
observationsForProfile()to support pressure, temperature, and relative humidity variables - Added URL-based experiment loading via the
?e=query parameter - Improved toast UX for promise-based operations with persistent error toasts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
apps/class-solid/src/lib/profiles.ts |
Added support for rh, T, and p variables in observation profiles; fixed template literal syntax in warning message |
apps/class-solid/src/lib/state.ts |
Implemented loadExperimentFromUrl() function to fetch and load experiments from external URLs via ?e= query parameter |
apps/class-solid/src/components/ui/toast.tsx |
Made error toasts persistent and added close button to rejected state for better error handling UX |
apps/class-solid/README.md |
Added comprehensive documentation for loading experiments from URLs, including local development setup example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Peter9192
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also works well. One side note is that if we want to add other variables we might need to extend the interface and schema here:
class-web/apps/class-solid/src/lib/experiment_config.ts
Lines 11 to 19 in 7da9999
| export interface Observation { | |
| name: string; | |
| height: number[]; | |
| pressure: number[]; | |
| temperature: number[]; | |
| relativeHumidity: number[]; | |
| windSpeed: number[]; | |
| windDirection: number[]; | |
| } |
Refs #184
To test use test setup from #187 and in vertical plot analyse select