Skip to content

Conversation

@sverhoeven
Copy link
Collaborator

@sverhoeven sverhoeven commented Nov 24, 2025

Refs #184

To test use test setup from #187 and in vertical plot analyse select

  • pressure
  • temperature
  • relative humidity

Does not add vertical velocity, because I do not know how and do not trust llms to do it correctly.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for plotting additional observation variables (pressure, temperature, relative humidity) in vertical profile analyses, along with a new feature to load experiments from external URLs.

Key changes:

  • Extended observationsForProfile() to support pressure, temperature, and relative humidity variables
  • Added URL-based experiment loading via the ?e= query parameter
  • Improved toast UX for promise-based operations with persistent error toasts

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
apps/class-solid/src/lib/profiles.ts Added support for rh, T, and p variables in observation profiles; fixed template literal syntax in warning message
apps/class-solid/src/lib/state.ts Implemented loadExperimentFromUrl() function to fetch and load experiments from external URLs via ?e= query parameter
apps/class-solid/src/components/ui/toast.tsx Made error toasts persistent and added close button to rejected state for better error handling UX
apps/class-solid/README.md Added comprehensive documentation for loading experiments from URLs, including local development setup example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also works well. One side note is that if we want to add other variables we might need to extend the interface and schema here:

export interface Observation {
name: string;
height: number[];
pressure: number[];
temperature: number[];
relativeHumidity: number[];
windSpeed: number[];
windDirection: number[];
}

@sverhoeven sverhoeven merged commit 82f5bef into main Nov 25, 2025
4 checks passed
@sverhoeven sverhoeven deleted the plot-more-observation-vars-184 branch November 25, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants