Skip to content

fix: security hardening - CEI pattern, over-withdrawal guard, debt settlement #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giwaov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: security hardening - CEI pattern, over-withdrawal guard, debt settlement #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/RefundProtocol.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ contract RefundProtocol is EIP712 {
revert CallerNotAllowed();
}

_settleDebt(msg.sender);

uint256 recipientBalance = balances[payment.to];

if (payment.amount > recipientBalance) {
Expand Down Expand Up @@ -298,6 +300,9 @@ contract RefundProtocol is EIP712 {
if (withdrawalAmount > payment.amount) {
revert InvalidWithdrawalAmount(paymentID, withdrawalAmount);
}
if (payment.withdrawnAmount + withdrawalAmount > payment.amount) {
revert InvalidWithdrawalAmount(paymentID, withdrawalAmount);
}
if (payment.to != recipient) {
revert PaymentDoesNotBelongToRecipient();
}
Expand Down Expand Up @@ -368,10 +373,11 @@ contract RefundProtocol is EIP712 {
if (payment.refunded) {
revert PaymentRefunded(paymentID);
}
fiatToken.transfer(payment.refundTo, payment.amount);

payments[paymentID].refunded = true;

fiatToken.transfer(payment.refundTo, payment.amount);

emit Refund(paymentID, payment.refundTo, payment.amount);
}

Expand Down