Errorhandling preprocessor #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
reviewed
Nov 21, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
Could you please resolve the conflicts on the branch too. Thank you.
Collaborator
Author
|
I also looked into the ticket Gerry referenced today in review #1432 This logic does not interfere with that portion of the codebase |
RamilCDISC
approved these changes
Nov 25, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds exception handling to improve error handling. This helps skipping rules instead of just breaking the execution. The PR was validated by:
- Reviewing the PR code for any unwanted changes or comments.
- Reviewing the PR Logic in context of AC.
- Validating all unit and regression testing pass.
- Ensuring all related testing is updated.
- Ensuring all the error message are clear and coherent.
- Ensuring the new custom exceptions follow the pattern of previous custom exceptions.
- Ensuring the exception is fully representative of code in the try block.
- Ensuring the validation does not break where it should just skip the in-processing rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom exceptions that get raised during several key parts of validation that were skipped by error coverage
Custom exceptions and messages with key metadata have been created to propagate up to validate single dataset which contains the try/except block that handles exceptions.
the attached issue has a rule/dataset that fails with relrec merge. Of note--i kept the caught stack trace as it is useful for development resolution of bugs but the added metadata context in the error messages should help rule authors with. Also of note--I was uncertain whether to assign a rule skip or not for these---I though it would be worthwhile to skip the rule to continue execution despite these being 'execution errors'.