hotfix #1494
Merged
hotfix #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
approved these changes
Dec 17, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR provides a hotfix for USDM bug. It covers the case of USDM which does not have a domain by utilizing the file name instead. All unit and regression testing pass. test_suite will be further updated to cover such cases in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes the error from #1445 where merged_domains was kept track of without accounting for USDM. We now do a check for domain and if it is not there, we use name. As USDM does not have domain, this prevents issues with merging datasets in preprocessor
to test:
Any of these:
DDF00103
DDF00093
DDF00092
DDF00181
DDF00127
DDF00094
DDF00048
DDF00095
you can see the type.decode.GeographicScope for DDF00093 on the right which is this branch now correctly merges and we get the 4 results that are expected from the rule and the test data. Right is the current engine and does not merge properly