Open
Conversation
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Merged
Member
Author
|
Ah, dear. I suppose this PR would also need to account for these lines of <properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>18</maven.compiler.source>
<maven.compiler.target>18</maven.compiler.target>
<exec.mainClass>org.caseontology.examples.CASE2Geo</exec.mainClass>
</properties>I'm fine with |
Member
|
There was a reason we needed Java 18 for one of the parts of this application. I can look into if we can downgrade it to support Java 11 and what the impacts would be. I would say, let's leave this open, but changes will be needed prior to merging. |
Member
Author
|
I don't think we need to force a downgrade. Could you highlight the >=18 requirement code with an inlined comment? And meanwhile, I might just close this PR anyway if there's an issue with hard-coding the Java version in XML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.