Merged
Conversation
ajnelson-nist
approved these changes
Jun 2, 2023
Member
ajnelson-nist
left a comment
ajnelson-nist
left a comment
There was a problem hiding this comment.
I'd prefer some of the test matrices be expanded a bit. I forget if matrix-nesting can be done precisely at the spots I suggested. I won't block the PR if you'd like to merge now.
Member
|
How about we merge this now and address the comments I made in follow-on PRs. They should all be straightforward if I understand the syntax and nesting right, but it might be a few round-trips with GitHub Actions. |
Member
|
All of my comments have been or are being addressed in other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CI workflows for the following:
pre-commitchecks.jsonfiles in thedata/directory