Skip to content

fix: enable tvOS compilation for XCUITest runner #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 4 commits into from
May 12, 2026
Merged

fix: enable tvOS compilation for XCUITest runner #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91fe7e6
fix: enable tvOS compilation for XCUITest runner
si-huynh May 10, 2026
5fa0d65
fix: harden tvOS runner interactions
thymikee May 11, 2026
b13c6d2
refactor: prune tvOS remote helpers
thymikee May 11, 2026
c7869a9
test: keep fallow focused on tvOS changes
thymikee May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 86 additions & 13 deletions ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+CommandExecution.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@ extension RunnerTests {
return (gestureStartUptimeMs, currentUptimeMs())
}

private func unsupportedResponse(for outcome: RunnerInteractionOutcome) -> Response? {
switch outcome {
case .performed:
return nil
case .unsupported(let message):
return Response(
ok: false,
error: ErrorPayload(code: "UNSUPPORTED_OPERATION", message: message)
)
}
}

func execute(command: Command) throws -> Response {
if Thread.isMainThread {
return try executeOnMainSafely(command: command)
Expand Down Expand Up @@ -231,11 +243,15 @@ extension RunnerTests {
case .tap:
if let text = command.text {
if let element = findElement(app: activeApp, text: text) {
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
element.tap()
outcome = activateElement(app: activeApp, element: element, action: "tap by text")
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand All @@ -249,11 +265,15 @@ extension RunnerTests {
}
if let x = command.x, let y = command.y {
let touchFrame = resolvedTouchVisualizationFrame(app: activeApp, x: x, y: y)
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
tapAt(app: activeApp, x: x, y: y)
outcome = tapAt(app: activeApp, x: x, y: y)
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand Down Expand Up @@ -309,13 +329,19 @@ extension RunnerTests {
let doubleTap = command.doubleTap ?? false
let touchFrame = resolvedTouchVisualizationFrame(app: activeApp, x: x, y: y)
if doubleTap {
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
runSeries(count: count, pauseMs: intervalMs) { _ in
doubleTapAt(app: activeApp, x: x, y: y)
if case .performed = outcome {
outcome = doubleTapAt(app: activeApp, x: x, y: y)
}
}
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand All @@ -329,13 +355,19 @@ extension RunnerTests {
)
)
}
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
runSeries(count: count, pauseMs: intervalMs) { _ in
tapAt(app: activeApp, x: x, y: y)
if case .performed = outcome {
outcome = tapAt(app: activeApp, x: x, y: y)
}
}
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand All @@ -354,11 +386,15 @@ extension RunnerTests {
}
let duration = (command.durationMs ?? 800) / 1000.0
let touchFrame = resolvedTouchVisualizationFrame(app: activeApp, x: x, y: y)
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
longPressAt(app: activeApp, x: x, y: y, duration: duration)
outcome = longPressAt(app: activeApp, x: x, y: y, duration: duration)
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand All @@ -377,11 +413,15 @@ extension RunnerTests {
}
let holdDuration = min(max((command.durationMs ?? 60) / 1000.0, 0.016), 10.0)
let dragFrame = resolvedDragVisualizationFrame(app: activeApp, x: x, y: y, x2: x2, y2: y2)
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
dragAt(app: activeApp, x: x, y: y, x2: x2, y2: y2, holdDuration: holdDuration)
outcome = dragAt(app: activeApp, x: x, y: y, x2: x2, y2: y2, holdDuration: holdDuration)
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand All @@ -407,18 +447,25 @@ extension RunnerTests {
return Response(ok: false, error: ErrorPayload(message: "dragSeries pattern must be one-way or ping-pong"))
}
let holdDuration = min(max((command.durationMs ?? 60) / 1000.0, 0.016), 10.0)
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
withTemporaryScrollIdleTimeoutIfSupported(activeApp) {
runSeries(count: count, pauseMs: pauseMs) { idx in
guard case .performed = outcome else {
return
}
let reverse = pattern == "ping-pong" && (idx % 2 == 1)
if reverse {
dragAt(app: activeApp, x: x2, y: y2, x2: x, y2: y, holdDuration: holdDuration)
outcome = dragAt(app: activeApp, x: x2, y: y2, x2: x, y2: y, holdDuration: holdDuration)
} else {
dragAt(app: activeApp, x: x, y: y, x2: x2, y2: y2, holdDuration: holdDuration)
outcome = dragAt(app: activeApp, x: x, y: y, x2: x2, y2: y2, holdDuration: holdDuration)
}
}
}
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
data: DataPayload(
Expand All @@ -427,6 +474,18 @@ extension RunnerTests {
gestureEndUptimeMs: timing.gestureEndUptimeMs
)
)
case .remotePress:
guard let button = tvRemoteButton(from: command.remoteButton) else {
return Response(ok: false, error: ErrorPayload(message: "remotePress requires remoteButton"))
}
let duration = (command.durationMs ?? 0) / 1000.0
guard pressTvRemote(button, duration: duration) else {
return Response(
ok: false,
error: ErrorPayload(code: "UNSUPPORTED_OPERATION", message: "remotePress is only supported on tvOS")
)
}
return Response(ok: true, data: DataPayload(message: "remote pressed"))
case .type:
guard let text = command.text else {
return Response(ok: false, error: ErrorPayload(message: "type requires text"))
Expand Down Expand Up @@ -633,13 +692,23 @@ extension RunnerTests {
return Response(ok: false, error: ErrorPayload(message: "alert not found"))
}
if action == "accept" {
let button = alert.buttons.allElementsBoundByIndex.first
button?.tap()
guard let button = alert.buttons.allElementsBoundByIndex.first else {
return Response(ok: false, error: ErrorPayload(message: "alert accept button not found"))
}
let outcome = activateElement(app: activeApp, element: button, action: "alert accept")
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(ok: true, data: DataPayload(message: "accepted"))
}
if action == "dismiss" {
let button = alert.buttons.allElementsBoundByIndex.last
button?.tap()
guard let button = alert.buttons.allElementsBoundByIndex.last else {
return Response(ok: false, error: ErrorPayload(message: "alert dismiss button not found"))
}
let outcome = activateElement(app: activeApp, element: button, action: "alert dismiss")
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(ok: true, data: DataPayload(message: "dismissed"))
}
let buttonLabels = alert.buttons.allElementsBoundByIndex.map { $0.label }
Expand All @@ -648,8 +717,12 @@ extension RunnerTests {
guard let scale = command.scale, scale > 0 else {
return Response(ok: false, error: ErrorPayload(message: "pinch requires scale > 0"))
}
var outcome = RunnerInteractionOutcome.performed
let timing = measureGesture {
pinch(app: activeApp, scale: scale, x: command.x, y: command.y)
outcome = pinch(app: activeApp, scale: scale, x: command.x, y: command.y)
}
if let response = unsupportedResponse(for: outcome) {
return response
}
return Response(
ok: true,
Expand Down
Loading
Loading