Skip to content

🎨 Palette: Add section header accessibility #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acebytes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add section header accessibility #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@
## 2024-05-25 - Dynamic Labels and Disabled State Tooltips
**Learning:** Users can feel confused when a primary button is disabled without explanation or when a long-running action lacks immediate inline text feedback on the button itself.
**Action:** In SwiftUI, enhance button accessibility and UX by adding `.help()` tooltips to explain the required state when disabled, and using dynamic labels (e.g., 'Scanning...') to provide immediate feedback during async operations.
## 2024-05-25 - Custom Section Header Accessibility
**Learning:** When implementing custom section header buttons with mixed content (icons, text, dynamic counts/sizes), VoiceOver needs help to correctly present the state and read all content.
**Action:** Apply `.accessibilityElement(children: .combine)`, a dynamic `.accessibilityValue` (e.g., 'Expanded' or 'Collapsed'), and an `.accessibilityHint`. Crucially, do not apply an explicit `.accessibilityLabel` to the combined element, as it overrides and hides the natural concatenation of the child text values.
3 changes: 3 additions & 0 deletions Sources/Cacheout/Views/NodeModulesSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ struct NodeModulesSection: View {
.contentShape(Rectangle())
}
.buttonStyle(.plain)
.accessibilityElement(children: .combine)
.accessibilityValue(isExpanded ? "Expanded" : "Collapsed")
.accessibilityHint("Toggles the node modules section")

if isExpanded && viewModel.isNodeModulesScanning {
HStack {
Expand Down
Loading