Skip to content

🎨 Palette: Add section header accessibility#295

Open
acebytes wants to merge 1 commit into
mainfrom
palette-accessibility-nodemodules-10714450869661459349
Open

🎨 Palette: Add section header accessibility#295
acebytes wants to merge 1 commit into
mainfrom
palette-accessibility-nodemodules-10714450869661459349

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Added accessibility to the NodeModulesSection header button.
🎯 Why: Makes the button state and dynamic contents properly readable for VoiceOver users without overriding inner text labels.
📸 Before/After: Accessibility attributes added.
♿ Accessibility: Uses .accessibilityElement(children: .combine), dynamic .accessibilityValue, and an .accessibilityHint while avoiding overriding the label.


PR created automatically by Jules for task 10714450869661459349 started by @acebytes

💡 What: Added accessibility to the NodeModulesSection header button.
🎯 Why: Makes the button state and dynamic contents properly readable for VoiceOver users without overriding inner text labels.
📸 Before/After: Accessibility attributes added.
♿ Accessibility: Uses `.accessibilityElement(children: .combine)`, dynamic `.accessibilityValue`, and an `.accessibilityHint` while avoiding overriding the label.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant