⚡ Bolt: Optimize hasSelection with short-circuit evaluation#294
⚡ Bolt: Optimize hasSelection with short-circuit evaluation#294acebytes wants to merge 1 commit into
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored the
hasSelectioncomputed property inCacheoutViewModelto use.contains(where: \.isSelected).🎯 Why: Previously, it checked
!selectedResults.isEmpty(which allocated an intermediate array via an eager.filterinside the property getter) andselectedNodeModulesSize > 0(which fully traversed all node modules items to compute their total size). This caused unnecessary memory allocations and O(N) traversals whenever the view checked for selections (e.g., disabling/enabling buttons).📊 Impact: Eliminates O(N) iterations and memory allocations in a frequently accessed SwiftUI computed property, allowing O(1) early returns as soon as a selected item is found.
🔬 Measurement: Profiling the view rendering time and memory allocations when toggling selections; there should be a visible reduction in transient memory allocations during interaction.
PR created automatically by Jules for task 3288895286523815742 started by @acebytes