Skip to content

fix: replace magic number with named constant for device activation states #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cachebag merged 1 commit into from
Jan 24, 2026
Merged

fix: replace magic number with named constant for device activation states #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nmrs/src/monitoring/bluetooth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use zbus::Connection;
use crate::dbus::{NMBluetoothProxy, NMDeviceProxy, NMProxy};
use crate::monitoring::transport::ActiveTransport;
use crate::try_log;
use crate::types::constants::device_type;
use crate::types::constants::{device_state, device_type};

pub(crate) struct Bluetooth;

Expand Down Expand Up @@ -65,7 +65,7 @@ pub(crate) async fn current_bluetooth_bdaddr(conn: &Connection) -> Option<String
// Check if device is in an active/connected state
let state = try_log!(dev.state().await, "Failed to get device state");
// State 100 = Activated (connected)
if state != 100 {
if state != device_state::ACTIVATED {
continue;
}

Expand Down Expand Up @@ -109,7 +109,7 @@ pub(crate) async fn current_bluetooth_info(conn: &Connection) -> Option<(String,
// Check if device is in an active/connected state
let state = try_log!(dev.state().await, "Failed to get device state");
// State 100 = Activated (connected)
if state != 100 {
if state != device_state::ACTIVATED {
continue;
}

Expand Down
Loading