-
-
Notifications
You must be signed in to change notification settings - Fork 10
fix: replace magic number with named constant for device activation states #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine but can you please read the contributing guidelines
Specifically here, the commit message should be:
fix(#229): replace magic number with named constantEnsure you simply amend this commit and just change the message, do not make a new commit.
|
@AK78gz I am talking about the commit message, not the PR description or title. You need to run something like: git commit --amend
<change title to: fix(#229): replace magic number with named constant>
git push --force |
|
i didnt write that when i made the changes it appeared like this TT |
cachebag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've made two commits but this change should be contained into one commit. Please start an interactive rebase and squash them into one commit.
cachebag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! Appreciate the contribution :)
Fix(#229): Replace magic number 100 with named constant