Skip to content

Conversation

@AK78gz
Copy link
Contributor

@AK78gz AK78gz commented Jan 24, 2026

Fix(#229): Replace magic number 100 with named constant

Copy link
Owner

@cachebag cachebag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but can you please read the contributing guidelines

Specifically here, the commit message should be:

fix(#229): replace magic number with named constant

Ensure you simply amend this commit and just change the message, do not make a new commit.

@cachebag cachebag changed the title Fix: issue 229 fix: replace magic number with named constant for device activation states Jan 24, 2026
@cachebag cachebag linked an issue Jan 24, 2026 that may be closed by this pull request
@AK78gz AK78gz changed the title fix: replace magic number with named constant for device activation states fix(#229): replace magic number with named constant for device activation states Jan 24, 2026
@cachebag
Copy link
Owner

cachebag commented Jan 24, 2026

@AK78gz I am talking about the commit message, not the PR description or title. You need to run something like:

git commit --amend 
<change title to: fix(#229): replace magic number with named constant>
git push --force

@cachebag cachebag changed the title fix(#229): replace magic number with named constant for device activation states fix: replace magic number with named constant for device activation states Jan 24, 2026
@cachebag cachebag added nmrs Changes attribute to nmrs refactor Change or improve code labels Jan 24, 2026
cachebag

This comment was marked as off-topic.

@AK78gz
Copy link
Contributor Author

AK78gz commented Jan 24, 2026

i didnt write that when i made the changes it appeared like this TT

Copy link
Owner

@cachebag cachebag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've made two commits but this change should be contained into one commit. Please start an interactive rebase and squash them into one commit.

Copy link
Owner

@cachebag cachebag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! Appreciate the contribution :)

@cachebag cachebag merged commit 24eded0 into cachebag:master Jan 24, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nmrs Changes attribute to nmrs refactor Change or improve code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Extract magic number 100 to named constant

2 participants