fix(debugger): use ENABLE_JS_DEBUGGER instead of JS_DEBUGGER #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch includes various fixes for how the debugger feature is enabled at compile time. - Provide stub implementation of `content_debugger` for builds where `ENABLE_JS_DEBUGGER` is not defined - Move `__wasilibc_initialize_environ` to debugger initialization to avoid implicit `wasi/environment` dependency. There are currently 3 entry points where the content debugger can be initialized: 1. `http/handler` -- debugger initialization is now explicitly called in the StarlingMonkey fetch event 2. `cli/run` -- debugger initialization should be called on engine initialization 3. `componentize-js` defined exports -- through componentize-js builtins on first call to exported function
tschneidereit
approved these changes
Jul 3, 2025
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you, this is a great improvement!
Member
Author
|
https://http-me.glitch.me that we use in some tests is unreliable. I think we should use local server for all the tests. The only problem with that is that it must use randomized port for parallel tests to work. We would need to pass the dynamic port somehow to the test component. Ideally we can use |
andreiltd
force-pushed
the
unhttp-debugger
branch
from
201a625 to
b7f6d21
Compare
This was referenced Jul 16, 2025
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes various fixes for how the debugger feature is enabled at compile time.
content_debuggerfor builds whereENABLE_JS_DEBUGGERis not defined__wasilibc_initialize_environto debugger initialization to avoid implicitwasi/environmentdependency.There are currently 3 entry points where the content debugger can be initialized:
http/handler-- debugger initialization is now explicitly called in the StarlingMonkey fetch event: herecli/run-- debugger initialization should be called on engine initialization: herecomponentize-jsdefined exports -- through componentize-js builtins on first call to exported function: feat: initialize debugger on first call ComponentizeJS#237