Skip to content

Conversation

@tschneidereit
Copy link
Member

@tschneidereit tschneidereit commented Aug 3, 2025

🤖 I have created a release beep boop

0.2.0 (2025-08-29)

Features

  • crypto: add support for PKCS#8 key import (#251) (059d09a)
  • dx: add default message for missing handler (#264) (58b6042)
  • implement AbortController and AbortSignal (#240) (215b1d9)

This PR was generated with Release Please. See documentation.

@tschneidereit
Copy link
Member Author

@andreiltd looks like the permissions are sorted out now. However, IIRC we weren't intending to call this release 1.0.0, right?

@andreiltd
Copy link
Member

Nice! Yeah, I think we need to start with some release and the bot will pick it up from there. If you see the previous PR commit message it includes footer: Release-As: . This is where you can override whatever default is.

@tschneidereit
Copy link
Member Author

Nice! Yeah, I think we need to start with some release and the bot will pick it up from there. If you see the previous PR commit message it includes footer: Release-As: . This is where you can override whatever default is.

Ah, okay. Would it be okay if I hand this back to you at this point? I'd like to focus on getting the SpiderMonkey update completed.

@andreiltd
Copy link
Member

Sure! What I would do is to close this PR, delete the branch and then push an empty commit to main, something like:

git commit --allow-empty -m "chore: prepare for release 0.2.0" -m "Release-As: 0.2.0"

Which should create a release PR again but using 0.2.0 this time. Does that sound OK?

@github-actions github-actions bot force-pushed the release-please--branches--main branch from 78789ad to 18cc0bf Compare August 4, 2025 11:29
@tschneidereit
Copy link
Member Author

Sounds good to me, though you might need to do this via a PR, since we don't allow pushes to main directly

@tschneidereit
Copy link
Member Author

Though maybe we can also just edit things here? I think we should update the release notes anyway to describe how this is the first release in this repo, but how there have been releases via ComponentizeJS

@andreiltd
Copy link
Member

andreiltd commented Aug 4, 2025

Though maybe we can also just edit things here?

I can try but I don't know if this would work. I couldn't find any docs that would explain if it's OK to manually edit the release PR.

EDIT: I can also try to test this on the fork, although so far it wasn't the most reliable approach. 😅

I think we should update the release notes anyway to describe how this is the first release in this repo, but how there have been releases via ComponentizeJS

It's possible to edit release notes after the release, isn't?

@tschneidereit
Copy link
Member Author

I can try but I don't know if this would work. I couldn't find any docs that would explain if it's OK to manually edit the release PR.

Hmm yeah, no idea. I wonder if we'd be best off doing the first release manually, with hand-written release notes?

It's possible to edit release notes after the release, isn't?

It is, but that wouldn't include the changelog itself, just the release notes in the UI.

@andreiltd
Copy link
Member

OK, so let's make the first release manually. The artifacts would be the source code only, right?

@tschneidereit
Copy link
Member Author

I think that's okay for this first release, yes: we wouldn't expect anyone to use this release's binaries anyway. We can call it 0.1.0, and add a CHANGELOG.md as described above.

@andreiltd
Copy link
Member

Here is the PR for changelog ,which I copied over from this PR: #259

As for the release notes I will initially just add:

While this is our initial release in this repository, StarlingMonkey build artifacts have been distributed as part of ComponentizJS releases for some time.

@github-actions github-actions bot force-pushed the release-please--branches--main branch from 18cc0bf to da6deaa Compare August 6, 2025 11:02
@tschneidereit
Copy link
Member Author

@andreiltd looks like things worked, and the initial changelog is properly picked up. We can now do the 0.1.0 release manually and then get a new release-please release going

@andreiltd
Copy link
Member

andreiltd commented Aug 6, 2025

Should I just copy the changelog content to release notes for 0.1.0?

@tschneidereit
Copy link
Member Author

That sounds good to me, yes

@andreiltd
Copy link
Member

I think we need some commit to land in main for this to be updated?

@tschneidereit
Copy link
Member Author

@andreiltd maybe land either or both of #240 and #251? Would be great to have those in!

@github-actions github-actions bot changed the title chore(main): release 1.0.0 chore(main): release 0.2.0 Aug 6, 2025
@github-actions github-actions bot force-pushed the release-please--branches--main branch 2 times, most recently from 8804aee to 91f98db Compare August 6, 2025 16:34
@andreiltd
Copy link
Member

I think this works as expected!

@andreiltd
Copy link
Member

Hey @tschneidereit, I thought we would merge this before ff140 so that we have a release with weval artifacts but that's not too important. I think that before landing the release PR we will have to remove weval artifacts from release script, right?

https://github.com/bytecodealliance/StarlingMonkey/blob/main/.github/workflows/release-please.yml#L60C1-L72C67

@tschneidereit
Copy link
Member Author

@andreiltd oh, my bad :( I hadn't considered that the 0.1.0 release doesn't have artifacts added to it, I'm sorry.

We can in theory manually upload them, but it's unclear if we have someone actively asking for them.

Agreed on the weval artifacts, those should be removed. Would you be up for doing that, or should I?

@andreiltd
Copy link
Member

No worries! Here is the PR to deweval artifacts: #261

@github-actions github-actions bot force-pushed the release-please--branches--main branch 2 times, most recently from 7e93f0d to b779e7c Compare August 13, 2025 09:31
@github-actions github-actions bot force-pushed the release-please--branches--main branch from b779e7c to 2c48f7f Compare August 18, 2025 10:46
@github-actions github-actions bot force-pushed the release-please--branches--main branch from 2c48f7f to 929ced0 Compare August 20, 2025 10:05
@andreiltd
Copy link
Member

Hey @tschneidereit, shlould we merge this? It will hopefully create gh release and uploads artifacts when it lands on main. 🤞

@tschneidereit
Copy link
Member Author

@andreiltd yes, we should! Since I'm marked as the author, it requires you to r+ it first, though. (I could override that, but don't see a good reason to.)

@tschneidereit tschneidereit merged commit 8ffd397 into main Sep 2, 2025
@tschneidereit tschneidereit deleted the release-please--branches--main branch September 2, 2025 15:08
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

🤖 Created releases:

🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants