-
Notifications
You must be signed in to change notification settings - Fork 47
chore(main): release 0.2.0 #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee2dc55 to
78789ad
Compare
|
@andreiltd looks like the permissions are sorted out now. However, IIRC we weren't intending to call this release 1.0.0, right? |
|
Nice! Yeah, I think we need to start with some release and the bot will pick it up from there. If you see the previous PR commit message it includes footer: Release-As: . This is where you can override whatever default is. |
Ah, okay. Would it be okay if I hand this back to you at this point? I'd like to focus on getting the SpiderMonkey update completed. |
|
Sure! What I would do is to close this PR, delete the branch and then push an empty commit to main, something like: Which should create a release PR again but using 0.2.0 this time. Does that sound OK? |
78789ad to
18cc0bf
Compare
|
Sounds good to me, though you might need to do this via a PR, since we don't allow pushes to main directly |
|
Though maybe we can also just edit things here? I think we should update the release notes anyway to describe how this is the first release in this repo, but how there have been releases via ComponentizeJS |
I can try but I don't know if this would work. I couldn't find any docs that would explain if it's OK to manually edit the release PR. EDIT: I can also try to test this on the fork, although so far it wasn't the most reliable approach. 😅
It's possible to edit release notes after the release, isn't? |
Hmm yeah, no idea. I wonder if we'd be best off doing the first release manually, with hand-written release notes?
It is, but that wouldn't include the changelog itself, just the release notes in the UI. |
|
OK, so let's make the first release manually. The artifacts would be the source code only, right? |
|
I think that's okay for this first release, yes: we wouldn't expect anyone to use this release's binaries anyway. We can call it |
|
Here is the PR for changelog ,which I copied over from this PR: #259 As for the release notes I will initially just add: While this is our initial release in this repository, StarlingMonkey build artifacts have been distributed as part of ComponentizJS releases for some time. |
18cc0bf to
da6deaa
Compare
|
@andreiltd looks like things worked, and the initial changelog is properly picked up. We can now do the 0.1.0 release manually and then get a new release-please release going |
|
Should I just copy the changelog content to release notes for 0.1.0? |
|
That sounds good to me, yes |
|
I think we need some commit to land in main for this to be updated? |
|
@andreiltd maybe land either or both of #240 and #251? Would be great to have those in! |
8804aee to
91f98db
Compare
|
I think this works as expected! |
|
Hey @tschneidereit, I thought we would merge this before ff140 so that we have a release with weval artifacts but that's not too important. I think that before landing the release PR we will have to remove weval artifacts from release script, right? |
|
@andreiltd oh, my bad :( I hadn't considered that the 0.1.0 release doesn't have artifacts added to it, I'm sorry. We can in theory manually upload them, but it's unclear if we have someone actively asking for them. Agreed on the weval artifacts, those should be removed. Would you be up for doing that, or should I? |
|
No worries! Here is the PR to deweval artifacts: #261 |
7e93f0d to
b779e7c
Compare
b779e7c to
2c48f7f
Compare
2c48f7f to
929ced0
Compare
929ced0 to
5d5ca7f
Compare
|
Hey @tschneidereit, shlould we merge this? It will hopefully create gh release and uploads artifacts when it lands on main. 🤞 |
|
@andreiltd yes, we should! Since I'm marked as the author, it requires you to r+ it first, though. (I could override that, but don't see a good reason to.) |
|
🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
0.2.0 (2025-08-29)
Features
This PR was generated with Release Please. See documentation.