Skip to content

fix: embedding splicer error handling #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vados-cosmonic merged 1 commit into from
Jul 16, 2025
Merged

fix: embedding splicer error handling #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions crates/spidermonkey-embedding-splicer/src/bindgen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,9 +859,7 @@ impl JsBindgen<'_> {
}
}

let err = if get_result_types(self.resolve, func.result)
.is_some_and(|(_, err_ty)| err_ty.is_some())
{
let err = if get_result_types(self.resolve, func.result).is_some() {
match abi {
AbiVariant::GuestExport => ErrHandling::ThrowResultErr,
AbiVariant::GuestImport => ErrHandling::ResultCatchHandler,
Expand Down
4 changes: 2 additions & 2 deletions test/cases/http-request/source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export function getResult() {

let responseBody;

const incomingBody = incomingResponse.consume().val;
const incomingBody = incomingResponse.consume();
{
const bodyStream = incomingBody.stream().val;
const bodyStream = incomingBody.stream();
// const bodyStreamPollable = bodyStream.subscribe();
const buf = bodyStream.blockingRead(500n);
// TODO: actual streaming
Expand Down
4 changes: 2 additions & 2 deletions test/cases/http-server/source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import {
export const incomingHandler = {
handle(incomingRequest, responseOutparam) {
const outgoingResponse = new OutgoingResponse(new Fields());
let outgoingBody = outgoingResponse.body().val;
let outgoingBody = outgoingResponse.body();
{
let outputStream = outgoingBody.write().val;
let outputStream = outgoingBody.write();
outputStream.blockingWriteAndFlush(
new Uint8Array(new TextEncoder().encode('Hello world!')),
);
Expand Down
Loading