fix: embedding splicer error handling #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
fix=embedding-splicer-error-handling-regression
branch
from
012cd90 to
592f849
Compare
This commit fixes a regression in function generation when error handling is involved. The buggy code over-eagerly checks whether there is an error type type present on a result, when there may legitimately not be (e.g. `result<t>` in WIT). The fix is to check *only* for whether the types are returned as a pair (indicating a `result`) at all.
vados-cosmonic
force-pushed
the
fix=embedding-splicer-error-handling-regression
branch
from
592f849 to
d1fd50f
Compare
tschneidereit
approved these changes
Jul 16, 2025
vados-cosmonic
deleted the
fix=embedding-splicer-error-handling-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression in function generation when error handling is involved.
The buggy code over-eagerly checks whether there is an error type type present on a result, when there may legitimately not be (e.g.
result<t>in WIT). The fix is to check only for whether the types are returned as a pair (indicating aresult) at all.