Skip to content

[Fix] sign/verify generic SHA algorithms with RSA keys #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljharb merged 1 commit into from
May 24, 2026
Merged

[Fix] sign/verify generic SHA algorithms with RSA keys #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions browser/algorithms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,24 +50,24 @@
"id": ""
},
"sha256": {
"sign": "ecdsa",
"sign": "ecdsa/rsa",
"hash": "sha256",
"id": ""
"id": "3031300d060960864801650304020105000420"
},
"sha224": {
"sign": "ecdsa",
"sign": "ecdsa/rsa",
"hash": "sha224",
"id": ""
"id": "302d300d06096086480165030402040500041c"
},
"sha384": {
"sign": "ecdsa",
"sign": "ecdsa/rsa",
"hash": "sha384",
"id": ""
"id": "3041300d060960864801650304020205000430"
},
"sha512": {
"sign": "ecdsa",
"sign": "ecdsa/rsa",
"hash": "sha512",
"id": ""
"id": "3051300d060960864801650304020305000440"
},
"DSA-SHA": {
"sign": "dsa",
Expand Down
23 changes: 23 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,29 @@ test('valid RSA fixtures', function (t) {
});
});

test('generic SHA algorithms sign RSA keys like node', function (t) {
var f = fixtures.valid.rsa[0];
var message = Buffer.from(f.message);
var priv = Buffer.from(f['private'], 'base64');
var pub = Buffer.from(f['public'], 'base64');

['sha224', 'sha256', 'sha384', 'sha512'].forEach(function (scheme) {
t.test('algorithm: ' + scheme, { skip: !(nCrypto.getHashes().indexOf(scheme) >= 0) }, function (st) {
var bSig = bCrypto.createSign(scheme).update(message).sign(priv);
var nSig = nCrypto.createSign(scheme).update(message).sign(priv);

st.equals(bSig.length, nSig.length, 'correct length');
st.equals(bSig.toString('hex'), nSig.toString('hex'), 'equal sigs');
st.ok(nCrypto.createVerify(scheme).update(message).verify(pub, bSig), 'node validates browser sig');
st.ok(bCrypto.createVerify(scheme).update(message).verify(pub, nSig), 'browser validates node sig');

st.end();
});
});

t.end();
});

// node has padding support since 8.0
// TODO: figure out why node v8.0 - v8.6 is broken
(semver.satisfies(process.versions.node, '>= 8.6') ? test : test.skip)('padding option', function (t) {
Expand Down
Loading