[Fix] sign/verify generic SHA algorithms with RSA keys#101
Merged
Conversation
Member
|
Thanks - just to clarify, are you Puneet Dixit or Deepak Kudi? Your commit has an author with a different name that's not linked to a github account. |
4b6e1e0 to
b8c2f78
Compare
ljharb
approved these changes
May 23, 2026
Member
ljharb
left a comment
There was a problem hiding this comment.
LGTM once the commit authorship is cleared up
b8c2f78 to
d2a3f56
Compare
Member
|
@puneetdixit200 that's fine, but can you explain the discrepancy? |
Contributor
Author
|
The mismatch came from an old local git identity on my machine. I amended the commit so the current author and committer are both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84
Verification